xclock: Changes to 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Nov 16 21:06:42 UTC 2024


 Clock.c  |   47 ++++++++++++++++++++++++-----------------------
 xclock.c |    2 +-
 2 files changed, 25 insertions(+), 24 deletions(-)

New commits:
commit 7e2f06430cc4f38b44c46091c2d97a33eb35d3d9
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Nov 11 12:53:57 2024 -0800

    Mark pointers const as suggested by cppcheck
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xclock/-/merge_requests/14>

commit 26d0038b53e8c7ef6223b15d0e00f3a5d677f4bf
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Nov 11 12:30:42 2024 -0800

    Clock.c: remove unused definitions of PI & TWOPI
    
    Clears warnings from clang 13:
    
    Clock.c:120:9: warning: macro is not used [-Wunused-macros]
    #define PI                      3.14159265358979
            ^
    Clock.c:121:9: warning: macro is not used [-Wunused-macros]
    #define TWOPI                   (2. * PI)
            ^
    
    Fixes: RCS revision 1.61 dated July 19, 1991
    ("eliminate use of sin() and cos() from the math library")
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xclock/-/merge_requests/14>

commit 6e3c02b128b58a5e6d0739589b5b00d695a42cf2
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Nov 11 12:23:43 2024 -0800

    Clock.c: fix two -Wextra-semi-stmt warnings
    
    Wrap donestr() macro definition in `do ... while (0)` to clear
    up warnings from clang 13:
    
    Clock.c:413:45: warning: empty expression statement has no effect;
     remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
        donestr(XftColor, xftColor, XtRXftColor);
                                                ^
    
    Clock.c:462:45: warning: empty expression statement has no effect;
     remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
            donestr(XftFont *, font, XtRXftFont);
                                                ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xclock/-/merge_requests/14>



More information about the xorg-commit mailing list