twm: Changes to 'master'

[GitLab Mirror]

 src/menus.c   |    1 
 src/session.c |  116 +++++++++++++++++++++++++++++++---------------------------
 src/session.h |    1 
 src/twm.c     |   22 +++++++++++
 src/util.c    |   19 +++++++++
 src/util.h    |    1 
 6 files changed, 106 insertions(+), 54 deletions(-)

New commits:
commit 64edeaaa4c7492d090b4069de2eae5f411ff1cd4
Author: Tim Wiederhake <twied at gmx.net>
Date:   Sat Mar 16 13:07:19 2024 +0100

    Fix read from uninitialized data
    
      Syscall param writev(vector[0]) points to uninitialised byte(s)
         at 0x4B836C0: writev (writev.c:26)
         by 0x4C74FBF: ??? (in /usr/lib/x86_64-linux-gnu/libxcb.so.1.1.0)
         by 0x4C753B0: xcb_writev (in /usr/lib/x86_64-linux-gnu/libxcb.so.1.1.0)
         by 0x48B2A24: _XSend (in /usr/lib/x86_64-linux-gnu/libX11.so.6.4.0)
         by 0x48B3088: _XReply (in /usr/lib/x86_64-linux-gnu/libX11.so.6.4.0)
         by 0x48AE6FE: XSync (in /usr/lib/x86_64-linux-gnu/libX11.so.6.4.0)
         by 0x11C523: HandleEnterNotify (events.c:2112)
         by 0x117847: DispatchEvent (events.c:335)
         by 0x117921: HandleEvents (events.c:363)
         by 0x12FCBD: main (twm.c:648)
       Address 0x5036874 is 148 bytes inside a block of size 16,384 alloc'd
         at 0x48459F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
         by 0x48A23AA: XOpenDisplay (in /usr/lib/x86_64-linux-gnu/libX11.so.6.4.0)
         by 0x49E5A12: XtOpenDisplay (in /usr/lib/x86_64-linux-gnu/libXt.so.6.0.0)
         by 0x12EB45: main (twm.c:319)
       Uninitialised value was created by a stack allocation
         at 0x12828E: send_clientmessage (menus.c:2861)
    
    Signed-off-by: Tim Wiederhake <twied at gmx.net>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/twm/-/merge_requests/29>

commit a62500505d57a4dc2c77bbbd7d0bfb832a5aa857
Author: Tim Wiederhake <twied at gmx.net>
Date:   Sat Mar 16 13:07:19 2024 +0100

    Fix memory leak in FindFontSet
    
    Valgrind results before:
    
      definitely lost: 800 bytes in 23 blocks
      indirectly lost: 872 bytes in 6 blocks
        possibly lost: 0 bytes in 0 blocks
      still reachable: 991,316 bytes in 1,795 blocks
           suppressed: 0 bytes in 0 blocks
    
    Valgrind results after:
    
      definitely lost: 200 bytes in 17 blocks
      indirectly lost: 0 bytes in 0 blocks
        possibly lost: 0 bytes in 0 blocks
      still reachable: 918,812 bytes in 994 blocks
           suppressed: 0 bytes in 0 blocks
    
    Signed-off-by: Tim Wiederhake <twied at gmx.net>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/twm/-/merge_requests/29>

commit e60c2914c354d4725d170e4fe4f14456caccd3cc
Author: Tim Wiederhake <twied at gmx.net>
Date:   Sat Mar 16 13:07:19 2024 +0100

    Fix memory leak in SaveYourselfPhase2CB
    
    Valgrind results before:
    
      definitely lost: 981 bytes in 37 blocks
      indirectly lost: 872 bytes in 6 blocks
        possibly lost: 0 bytes in 0 blocks
      still reachable: 991,316 bytes in 1,795 blocks
           suppressed: 0 bytes in 0 blocks
    
    Valgrind results after:
    
      definitely lost: 800 bytes in 23 blocks
      indirectly lost: 872 bytes in 6 blocks
        possibly lost: 0 bytes in 0 blocks
      still reachable: 991,316 bytes in 1,795 blocks
           suppressed: 0 bytes in 0 blocks
    
    Signed-off-by: Tim Wiederhake <twied at gmx.net>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/twm/-/merge_requests/29>