xinit: Changes to 'master'

[GitLab Mirror]

 configure.ac |    6 +++++-
 xinit.c      |   37 ++++++++++++++++++++++++++-----------
 2 files changed, 31 insertions(+), 12 deletions(-)

New commits:
commit 6ad6378928dd1eec2a3e159f92b53b68ce3884ba
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Dec 7 10:27:28 2024 -0800

    Use asprintf() if available
    
    If we can use it, then we avoid a couple of clang warnings:
    xinit.c:534:20: warning: implicit conversion changes signedness:
     'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
            len = numn + 1;
                ~ ~~~~~^~~
    xinit.c:540:40: warning: implicit conversion changes signedness:
     'int' to 'unsigned long' [-Wsign-conversion]
            len = strlen(windowpath) + 1 + numn + 1;
                                         ~ ^~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xinit/-/merge_requests/20>

commit 0420d0b58b34217e496caa7dfa904bd833c00133
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Dec 7 10:03:33 2024 -0800

    Use ptrdiff_t to store results of pointer subtraction
    
    Clears warnings from clang of:
    xinit.c:174:34: warning: implicit conversion loses integer precision:
     'long' to 'int' [-Wshorten-64-to-32]
        start_of_client_args = (cptr - client);
                             ~  ~~~~~^~~~~~~~
    xinit.c:203:34: warning: implicit conversion loses integer precision:
     'long' to 'int' [-Wshorten-64-to-32]
        start_of_server_args = (sptr - server);
                             ~  ~~~~~^~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xinit/-/merge_requests/20>

commit 35de4b9d29a78e0f95539c0540b8b173cae71766
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Dec 7 09:55:49 2024 -0800

    Clear -Wunused-parameter warnings from clang
    
    Add _X_UNUSED to parameters required by callback definitions which we
    don't acutally use.
    
    Clears clang warnings of:
    
    xinit.c:129:15: warning: unused parameter 'sig' [-Wunused-parameter]
    sigIgnore(int sig)
                  ^
    xinit.c:581:20: warning: unused parameter 'dpy' [-Wunused-parameter]
    ignorexio(Display *dpy)
                       ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xinit/-/merge_requests/20>

commit 8a9c76dd35d5f824669ea2c7268cd7b4684c8687
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Dec 7 09:50:10 2024 -0800

    Mark global variables as static since there's only one source file
    
    Clears 8 warnings from clang of the form:
    
    xinit.c:61:13: warning: no previous extern declaration for non-static
     variable 'bindir' [-Wmissing-variable-declarations]
    const char *bindir = BINDIR;
                ^
    xinit.c:61:7: note: declare 'static' if the variable is not intended
     to be used outside of this translation unit
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xinit/-/merge_requests/20>