libXi: Changes to 'master'
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Aug 28 04:25:54 UTC 2024
src/XGetFCtl.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
New commits:
commit a5af26c654b4da5fd5eaaeaa2173c734ab9e63ec
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date: Tue Aug 27 11:01:06 2024 +1000
XGetFeedbackControl: skip over unknown feedback controls
If the server sends an unknown feedback control class we would allocate
the amount of *protocol* bytes for the client representation but then
later mess up the actual composition of the classes due to
Feedback->length never being initialized.
So while in theory it looks like this:
|-------------- allocated size -----------------|
[led feedback] [ ?unknown? ] [kbd feedback][....]
with unknown being the size of the class on the protocol,
in practice it looks like this:
|-------------- allocated size -----------------|
[led feedback] [ ?unknown? ] [kbd feedback][...]
with unknown being the size of whatever was in the Feeback->length
pointed to at the time. The content of unknown is never initialized.
Fix this by making unknown classes disappear so the above becomes:
|------- allocated size ---------|
[led feedback][kbd feedback][....]
Closes #16
Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxi/-/merge_requests/18>
More information about the xorg-commit
mailing list