libICE: Changes to 'master'

[GitLab Mirror]

 configure.ac             |    2 
 include/X11/ICE/ICEmsg.h |   18 ++++--
 src/ICElibint.h          |   14 ++++
 src/connect.c            |   43 +++++++++++---
 src/misc.c               |  141 +++++++++++++++++++----------------------------
 src/process.c            |   23 +++++--
 src/protosetup.c         |   11 +++
 7 files changed, 146 insertions(+), 106 deletions(-)

New commits:
commit 96c84e563610d5c7846e601605f675f3d3840dd2
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Wed Sep 14 16:29:32 2022 -0700

    Handle arrays too large to fit in iceConn buffers
    
    Fixes numerous gcc warnings of the form:
    
    connect.c: In function ‘IceOpenConnection’:
    ICElibint.h:160:25: warning: potential null pointer dereference [-Wnull-dereference]
         *((CARD16 *) _pBuf) = _val; \
                             ^
    ICElibint.h:174:5: note: in expansion of macro ‘STORE_CARD16’
         STORE_CARD16 (_pBuf, _len); \
         ^~~~~~~~~~~~
    connect.c:351:5: note: in expansion of macro ‘STORE_STRING’
         STORE_STRING (pData, IceReleaseString);
         ^~~~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 0269c687e954db7aca2a4344e32cb203315a00b6
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Wed Sep 7 14:22:44 2022 -0700

    ICEmsg.h: Add static asserts that message header length <= ICE_OUTBUFSIZE
    
    A message header length larger than ICE_OUTBUFSIZE will cause
    buffer overflows.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit b399fc2b3c5c2cf5f0d36d98c372f353a8186d15
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Wed Sep 7 13:37:34 2022 -0700

    IceFlush: signal fatal I/O error if bufptr is past end of buffer
    
    It should never happen, but has been possible in the past when
    we didn't handle buffer checks properly - this would help us
    catch it if a similar mistake ever happens again (or the wrong
    memory pointer gets corrupted by something else).
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 918d58772595e7cd9907a7b08874196442fbf599
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Wed Sep 7 13:36:28 2022 -0700

    Refactor Fatal I/O error handling into a common function
    
    Reduce duplicated code in _IceRead() and _IceWrite()
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 6ca1ea376c7c6c9dc719d607b7684d87bcf96712
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Wed Sep 7 11:33:13 2022 -0700

    IceGetHeaderExtra: only include extra space in outbufptr if there's room
    
    If there's not room for it in the buffer, we already set pData to
    NULL, but still set the outbufptr to include the space, which could
    lead to IceFlush() reading past the end of the buffer.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>