xkbevd: Changes to 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Oct 28 01:28:07 UTC 2022


 .git-blame-ignore-revs |   18 ++++++++++++++++++
 .gitlab-ci.yml         |    4 ++--
 cfgscan.c              |    9 ++++-----
 printev.c              |   11 ++++-------
 xkbevd.c               |   33 +++++++++++++++++----------------
 5 files changed, 45 insertions(+), 30 deletions(-)

New commits:
commit 2ab380b66b2bca181b01d375779bfdff167744a6
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Oct 22 12:09:28 2022 -0700

    Add .git-blame-ignore-revs to hide whitespace commits from git blame
    
    To use this in your local repo clone, you will need to either run
    `git blame --ignore-revs-file .git-blame-ignore-revs`
    or set it permanently with
    `git config blame.ignoreRevsFile .git-blame-ignore-revs`
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit f7f9e4590a75d629b3ca65887b6e477a72ba39b7
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Oct 22 12:01:47 2022 -0700

    eventTypeToString: remove unnecessary strcpy to static buffer
    
    Since the results are just passed to fprintf(), we can just return
    a pointer to the string constants directly.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit be8848c2203b489854982eb74727928cb5b622da
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Oct 22 11:58:40 2022 -0700

    xkbevd.c: Update default DFLT_XKB_CONFIG_ROOT path
    
    Normally overriden by -DDFLT_XKB_CONFIG_ROOT in Makefile
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 0bb93230c5263ebfc4cc25125f1c76f1d6a7382a
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Oct 22 11:42:10 2022 -0700

    cfgscan: check if character is EOF before calling isalpha or isdigit
    
    Resolves cppcheck warnings:
    
    cfgscan.c:475:22: warning: Either the condition 'ch==-1' is redundant or
     isalpha() argument nr 1 can have invalid value. The value is -1 but the
     valid values are '0:255'. [invalidFunctionArg]
        else if (isalpha(ch) || (ch == '_'))
                         ^
    cfgscan.c:479:17: note: Assuming that condition 'ch==-1' is not redundant
        else if (ch == EOF)
                    ^
    cfgscan.c:475:22: note: Invalid argument
        else if (isalpha(ch) || (ch == '_'))
                         ^
    cfgscan.c:477:22: warning: Either the condition 'ch==-1' is redundant or
     isdigit() argument nr 1 can have invalid value. The value is -1 but the
     valid values are '0:255'. [invalidFunctionArg]
        else if (isdigit(ch))
                         ^
    cfgscan.c:479:17: note: Assuming that condition 'ch==-1' is not redundant
        else if (ch == EOF)
                    ^
    cfgscan.c:477:22: note: Invalid argument
        else if (isdigit(ch))
                         ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 00becc220c242cf7f37cc139db1e7f7b9c475d15
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Oct 22 11:16:46 2022 -0700

    Rename shadowed variables
    
    Fixes gcc warnings of:
    
    xkbevd.c: In function ‘GetDisplay’:
    xkbevd.c:219:33: warning: declaration of ‘dpyName’ shadows a global declaration [-Wshadow]
     GetDisplay(char *program, char *dpyName, int *opcodeRtrn, int *evBaseRtrn)
                                     ^~~~~~~
    xkbevd.c:55:17: note: shadowed declaration is here
     static char *   dpyName = NULL;
                     ^~~~~~~
    xkbevd.c:222:14: warning: declaration of ‘dpy’ shadows a global declaration [-Wshadow]
         Display *dpy;
                  ^~~
    xkbevd.c:56:17: note: shadowed declaration is here
     Display *       dpy = NULL;
                     ^~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 199b00b2bbaf2dd90d95e9e3a77c738269ed3804
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Oct 22 11:11:00 2022 -0700

    Variable scope reduction as suggested by cppcheck
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit fa4be31580f5ea62556ac02dc2e07737a758de87
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jul 28 17:30:21 2022 -0700

    gitlab CI: stop requiring Signed-off-by in commits
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>



More information about the xorg-commit mailing list