xlsclients: Changes to 'master'

[GitLab Mirror]

 .gitlab-ci.yml |    4 ++--
 xlsclients.c   |   34 ++++++++++++++++++++++------------
 2 files changed, 24 insertions(+), 14 deletions(-)

New commits:
commit 0cf445b33e15df1c194f2a8e2683ba5b1b2e4254
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Oct 24 18:11:31 2022 -0700

    Resolve implicit conversion warnings from clang
    
    xlsclients.c:303:47: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
        qt_reply = malloc(sizeof(*qt_reply) * cs->list_length);
                                            ~ ~~~~^~~~~~~~~~~
    xlsclients.c:323:31: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
        cs = malloc(sizeof(*cs) + child_count * (sizeof(*cs->prop_cookie) + sizeof(*cs->tree_cookie) + sizeof(*cs->win)));
                                  ^~~~~~~~~~~ ~
    xlsclients.c:515:38: warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
                class_len = wm_class->value_len - name_len;
                          ~ ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
    xlsclients.c:515:40: warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
                class_len = wm_class->value_len - name_len;
                                                ~ ^~~~~~~~
    xlsclients.c:514:56: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
                name_len = strnlen(res_name, wm_class->value_len) + 1;
                         ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
    xlsclients.c:520:15: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
                    class_len = strlen(res_class);
                              ~ ^~~~~~~~~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 70b32490063a227e48fe06ec2e0e2c976b6eff12
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Oct 24 18:02:18 2022 -0700

    usage: add cold & noreturn attributes to function
    
    As suggested by clang:
    xlsclients.c:69:1: warning: function 'usage' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    {
    ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 99c7b421dbd083c3c16158982eabb28758868188
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Oct 24 17:58:51 2022 -0700

    Handle -Wsign-compare warnings
    
    xlsclients.c: In function ‘show_client_properties’:
    xlsclients.c:485:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
      485 |     for (i = 0; i < command->value_len && charsleft > 0; ) {
          |                   ^
    xlsclients.c:488:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
      488 |         if (i < command->value_len && charsleft > 0) {
          |               ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 977636f190306bddbe3d09123283484ff5bd1b33
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Mon Oct 24 17:55:37 2022 -0700

    Quiet -Wmaybe-uninitialized warnings from gcc
    
    I think these were false positives, as the accesses were all inside
    "if (cs->verbose)" checks, matching the initialization case for them,
    but this makes gcc stop warning.
    
    xlsclients.c:531:13: warning: ‘wm_class’ may be used uninitialized [-Wmaybe-uninitialized]
      531 |             free(wm_class);
          |             ^~~~~~~~~~~~~~
    xlsclients.c:440:31: note: ‘wm_class’ was declared here
      440 |     xcb_get_property_reply_t *wm_class;
          |                               ^~~~~~~~
    xlsclients.c:475:35: warning: ‘icon_name’ may be used uninitialized [-Wmaybe-uninitialized]
      475 |         if (icon_name && icon_name->type)
          |                          ~~~~~~~~~^~~~~~
    xlsclients.c:439:31: note: ‘icon_name’ was declared here
      439 |     xcb_get_property_reply_t *icon_name;
          |                               ^~~~~~~~~
    xlsclients.c:527:13: warning: ‘name’ may be used uninitialized [-Wmaybe-uninitialized]
      527 |             free(name);
          |             ^~~~~~~~~~
    xlsclients.c:438:31: note: ‘name’ was declared here
      438 |     xcb_get_property_reply_t *name;
          |                               ^~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit c8d8a4e66279130605b73b5dcef61c31ae414d57
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jul 28 17:30:21 2022 -0700

    gitlab CI: stop requiring Signed-off-by in commits
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>