xcmsdb: Changes to 'master'

[GitLab Mirror]

 loadData.c | 2347 +++++++++++++++++++++++++++++++------------------------------
 xcmsdb.c   | 1124 ++++++++++++++---------------
 2 files changed, 1774 insertions(+), 1697 deletions(-)

New commits:
commit 337a55d303d76aa4f3f6d1e4d7885544436ee2be
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Apr 30 11:38:44 2022 -0700

    LoadSCCData: avoid leaking memory if we give up early
    
    Resolves issues reported by Oracle Parfait static analyser:
    
    Error: Memory leak
       Memory leak [memory-leak] (CWE 401):
          Memory leak of pointer pCurrent allocated with calloc(1, 112)
            at line 1615 of app/xcmsdb/loadData.c in function 'LoadSCCData'.
              pCurrent allocated at line 1600 with calloc(1, 112)
    Error: Memory leak
       Memory leak [memory-leak] (CWE 401):
          Memory leak of pointer pCurrent allocated with calloc(1, 112)
            at line 1634 of app/xcmsdb/loadData.c in function 'LoadSCCData'.
              pCurrent allocated at line 1600 with calloc(1, 112)
              pCurrent leaks when VisualFlag == 0 at line 1618
                  and VisualFlag == 0 at line 1626.
    Error: Memory leak
       Memory leak [memory-leak] (CWE 401):
          Memory leak of pointer pCurrent allocated with calloc(1, 112)
            at line 1656 of app/xcmsdb/loadData.c in function 'LoadSCCData'.
              pCurrent allocated at line 1600 with calloc(1, 112)
              pCurrent leaks when VisualFlag == 0 at line 1618
                  and VisualFlag == 0 at line 1626
                  and pCurrent->nTables != 0 at line 1628
                  and pCurrent->nTables != 1 at line 1628
                  and token3 == NULL at line 1642
                  and pCurrent->nTables is 3 at line 1648
                  and pCurrent->pRedTbl == NULL at line 1651.
       Memory leak [memory-leak] (CWE 401):
          Memory leak of pointer pCurrent allocated with calloc(1, 112)
            at line 1664 of app/xcmsdb/loadData.c in function 'LoadSCCData'.
              pCurrent allocated at line 1600 with calloc(1, 112)
              pCurrent leaks when VisualFlag == 0 at line 1618
                  and VisualFlag == 0 at line 1626
                  and pCurrent->nTables != 0 at line 1628
                  and pCurrent->nTables != 1 at line 1628
                  and token3 == NULL at line 1642
                  and pCurrent->nTables is 3 at line 1648
                  and pCurrent->pGreenTbl == NULL at line 1659.
       Memory leak [memory-leak] (CWE 401):
          Memory leak of pointer pCurrent allocated with calloc(1, 112)
            at line 1672 of app/xcmsdb/loadData.c in function 'LoadSCCData'.
              pCurrent allocated at line 1600 with calloc(1, 112)
              pCurrent leaks when VisualFlag == 0 at line 1618
                  and VisualFlag == 0 at line 1626
                  and pCurrent->nTables != 0 at line 1628
                  and pCurrent->nTables != 1 at line 1628
                  and token3 == NULL at line 1642
                  and pCurrent->nTables is 3 at line 1648
                  and pCurrent->pBlueTbl == NULL at line 1667.
       Memory leak [memory-leak] (CWE 401):
          Memory leak of pointer pCurrent allocated with calloc(1, 112)
            at line 1685 of app/xcmsdb/loadData.c in function 'LoadSCCData'.
              pCurrent allocated at line 1600 with calloc(1, 112)
              pCurrent leaks when VisualFlag == 0 at line 1618
                  and VisualFlag == 0 at line 1626
                  and pCurrent->nTables != 0 at line 1628
                  and pCurrent->nTables == 1 at line 1628
                  and token3 == NULL at line 1642
                  and pCurrent->nTables is 1 at line 1648
                  and pCurrent->pRedTbl == NULL at line 1680.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 6ff9e623b48a8998324a75ebaadb6adc97b189ae
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Apr 30 11:31:33 2022 -0700

    Remove unnecessary casts and make allocation failure checks more consistent
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 54b7f6247be611d1f357220a59be05322d78998a
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Apr 30 11:02:27 2022 -0700

    Adopt X.Org standard coding style
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>