smproxy: Changes to 'master'

[GitLab Mirror]

 save.c    |   36 ++++++++++++++++--------------------
 smproxy.c |   50 ++++++++++++++++++++++++++++----------------------
 2 files changed, 44 insertions(+), 42 deletions(-)

New commits:
commit f92f80fbb8926d980a6a46c488f7f60a35c9bf9c
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Aug 14 10:41:39 2022 -0700

    CheckFullyQuantifiedName: improve gethostname() handling
    
    Handle errors and use HOST_NAME_MAX for the buffer size if it is
    defined by <limits.h>
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 5bf2e626a25f0ac1503effbf89c01573392ea658
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Aug 14 10:15:06 2022 -0700

    CheckFullyQuantifiedName: return unqualified name if alloc fails
    
    Makes a failure to allocate by asprintf() match other failure
    cases and return the unqualified name instead of NULL.
    
    Fixes gcc warning:
    smproxy.c: In function ‘FinishSaveYourself’:
    smproxy.c:269:31: warning: ‘%s’ directive argument is null [-Wformat-truncation=]
                       "rstart-rsh/%s", fullyQuantifiedName);
                                   ^~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 88262a274bdd850e14cc27dd3d421182bbc157d5
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Aug 14 10:10:23 2022 -0700

    Use calloc instead of malloc to allocate arrays
    
    Most important in ReadProxyFileEntry, if we goto give_up before we
    finish initializing the array, makes sure we don't try to free
    uninitialized pointers during cleanup pass.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 0c55e2eabe6755b88de9835da8185a52b7712847
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Aug 14 10:04:12 2022 -0700

    Remove or correct obsolete casts
    
    Bring code up to C89 levels
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 5fdd590f9b9a9f5aa3a60e44fe8f010c43f8c54e
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Aug 14 09:49:22 2022 -0700

    NullIceErrorHandler: make arg names match between definition & declaration
    
    Solves cppcheck warning:
    [smproxy.c:73] -> [smproxy.c:448]: (style, inconclusive)
      Function 'NullIceErrorHandler' argument 3 names different:
        declaration 'offendingMinorOpCode' definition 'offendingMinorOpcode'.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit f4800d0cfbadf9fc50dddbe2b1eb8d62548d7fe5
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Aug 14 09:47:41 2022 -0700

    Reduce variable scopes as suggested by cppcheck
    
    [save.c:203]: (style) The scope of the variable 'i' can be reduced.
    [save.c:457]: (style) The scope of the variable 'i' can be reduced.
    [smproxy.c:101]: (style) The scope of the variable 'i' can be reduced.
    [smproxy.c:1114]: (style) The scope of the variable 'client_window' can be reduced.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>