showfont: Changes to 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Aug 18 23:01:13 UTC 2022


 showfont.c |   54 ++++++++++++++++++++++--------------------------------
 1 file changed, 22 insertions(+), 32 deletions(-)

New commits:
commit 7d35ec8371c7744359b9b63017e3851c46ad4c16
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Aug 13 18:04:41 2022 -0700

    Take care of -Wsign-compare warnings
    
    showfont.c: In function ‘show_glyphs’:
    showfont.c:218:17: warning: comparison between signed and unsigned
      integer expressions [-Wsign-compare]
          if (offset != offsets[ch].position)
                     ^~
    showfont.c:249:29: warning: comparison between signed and unsigned
      integer expressions [-Wsign-compare]
          if (offsets[ch].length != bottom * bpr) {
                                 ^~
    showfont.c: In function ‘main’:
    showfont.c:456:23: warning: comparison between signed and unsigned
      integer expressions [-Wsign-compare]
       ((unsigned)first_ch >= (first.low + (first.high << 8)))) {
                           ^~
    showfont.c:462:21: warning: comparison between signed and unsigned
      integer expressions [-Wsign-compare]
       ((unsigned)end_ch <= (last.low + (last.high << 8)))) {
                         ^~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 4618f9dbbcb93805b64d86fae3a1ec82f8f6849b
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Aug 13 17:22:20 2022 -0700

    Reduce variable scopes as suggested by cppcheck
    
    [showfont.c:170]: (style) The scope of the variable 'err' can be reduced.
    [showfont.c:172]: (style) The scope of the variable 'start' can be reduced.
    [showfont.c:179]: (style) The scope of the variable 'format' can be reduced.
    [showfont.c:380]: (style) The scope of the variable 'show_all' can be reduced.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>



More information about the xorg-commit mailing list