xsm: Changes to 'master'

[GitLab Mirror]

 choose.c     |    4 ++--
 configure.ac |    2 +-
 info.c       |    6 +++---
 save.c       |    6 +++---
 saveutil.c   |   11 +++++------
 xsm.h        |    6 ++++--
 6 files changed, 18 insertions(+), 17 deletions(-)

New commits:
commit 107fbd198f2d4cec9efb54e89a568a595ac2d1e3
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Nov 28 11:02:18 2021 -0800

    Add noreturn attributes suggested by gcc
    
    misc.c: In function ‘nomem’:
    misc.c:106:1: warning: function might be candidate for
     attribute ‘noreturn’ [-Wsuggest-attribute=noreturn]
      106 | nomem(void)
          | ^~~~~
    xsm.c:657:1: warning: function might be candidate for
     attribute ‘noreturn’ [-Wsuggest-attribute=noreturn]
      657 | EndSession(int status)
          | ^~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 416a3fc806f47b158b489bb44f7709fc44fa4f3e
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Nov 28 10:54:06 2021 -0800

    WriteSave: allocate enough room for full session_save_file in error
    
    Clears warning from gcc 11.2:
    
    saveutil.c: In function ‘WriteSave’:
    saveutil.c:315:75: warning: ‘%s’ directive output may be truncated
     writing up to 1023 bytes into a region of size 221 [-Wformat-truncation=]
      315 |         snprintf (msg, sizeof(msg), "%s: Error creating session save file %s",
          |                                                                           ^~
      316 |                   Argv[0], session_save_file);
          |                            ~~~~~~~~~~~~~~~~~
    saveutil.c:315:9: note: ‘snprintf’ output 36 or more bytes (assuming 1059)
     into a destination of size 256
      315 |         snprintf (msg, sizeof(msg), "%s: Error creating session save file %s",
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      316 |                   Argv[0], session_save_file);
          |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 6a902614350d46b759fc09a88daf9aff11f79ee8
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Nov 28 10:42:03 2021 -0800

    Increase size of number buffer to fit all possible values
    
    Clears gcc warning of:
    
    info.c: In function ‘DisplayProps’:
    info.c:214:44: warning: ‘snprintf’ output may be truncated before the
     last format character [-Wformat-truncation=]
           snprintf (number, sizeof(number), "%d", propnum);
                                                ^
    info.c:214:7: note: ‘snprintf’ output between 2 and 11 bytes into a
     destination of size 10
           snprintf (number, sizeof(number), "%d", propnum);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 4bf092e35a92b4fb613f4fee01d5ab26a612ddb6
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Nov 28 10:38:43 2021 -0800

    Use _CONST_X_STRING to make libXt declare String as const char *
    
    Clears 5 -Wincompatible-pointer-types warnings
    and 18 -Wdiscarded-qualifiers warnings from gcc
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>