xserver: Branch 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Aug 6 16:00:39 UTC 2021


 xfixes/xfixes.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 31fb35a7afc782e857bf60e524e7d966dbcd2551
Author: Demi Marie Obenour <demi at invisiblethingslab.com>
Date:   Tue Jul 20 22:58:42 2021 -0400

    XFixes: add version check for byteswapped clients
    
    The version check for byteswapped clients was missing.

diff --git a/xfixes/xfixes.c b/xfixes/xfixes.c
index 3ba7314a7..ecb6f298f 100644
--- a/xfixes/xfixes.c
+++ b/xfixes/xfixes.c
@@ -215,7 +215,11 @@ static _X_COLD int
 SProcXFixesDispatch(ClientPtr client)
 {
     REQUEST(xXFixesReq);
-    if (stuff->xfixesReqType >= XFixesNumberRequests)
+    XFixesClientPtr pXFixesClient = GetXFixesClient(client);
+
+    if (pXFixesClient->major_version >= ARRAY_SIZE(version_requests))
+        return BadRequest;
+    if (stuff->xfixesReqType > version_requests[pXFixesClient->major_version])
         return BadRequest;
     return (*SProcXFixesVector[stuff->xfixesReqType]) (client);
 }


More information about the xorg-commit mailing list