libXcursor: Changes to 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Sep 8 17:30:49 UTC 2020


 include/X11/Xcursor/Xcursor.h.in |    3 ++-
 src/file.c                       |   11 ++++++-----
 2 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 204b6f130858ef038832887ea10488e7aed711a6
Author: Valentin <vakevk+git at gmail.com>
Date:   Sun Aug 30 15:37:19 2020 +0200

    Fix undefined behavior
    
    Without the casts the bytes accesses get converted to int. but int is
    not guaranteed to be 4 bytes large. Even when it is 4 bytes large
    `bytes[3] << 24` does not fit because int is signed.

commit 448398a3b97a77648e90cc993597bafb2ad95eac
Author: Valentin <vakevk+git at gmail.com>
Date:   Sun Aug 30 15:35:16 2020 +0200

    Use fixed size integer type
    
    This type is meant to be 4 bytes large as seen in _XcursorReadUInt which
    always reads 4 bytes. An unsigned int is often 4 bytes large but this
    isnt' guaranteed so it is cleaner to use the exact type we want.



More information about the xorg-commit mailing list