xdm: Changes to 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sun Nov 1 18:37:25 UTC 2020


 greeter/Login.c |    4 ++--
 xdm/auth.c      |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit c84d3f77abdb5502140ba36137c25a6dd07df756
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Nov 1 10:20:02 2020 -0800

    doneAddrs: reset addrs to NULL after freeing list
    
    Resolves warning from Oracle Parfait static analyzer:
    
    Warning: Dangling pointer
       Dangling pointer [dangling-pointer]:
          Invalid pointer is accessible to caller via global addrs
            at line 664 of xdm/auth.c in function 'doneAddrs'.
            Invalid pointer accessible via global addrs at line 646
              a accessed from addrs at line 658 in function 'doneAddrs'
              a freed with free at line 662
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 9505d391c72c90635453cc160b6f64e02da6a318
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Nov 1 10:05:11 2020 -0800

    Greeter: add parens to DRAW_STRING & TEXT_WIDTH macros for safety
    
    Oracle Parfait static analyser points out it wasn't clear if cast or
    arithmetic operation in arguments at lines 410, 416, 431, & 433 was
    intended to be done first, so we'll make it explicit.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>



More information about the xorg-commit mailing list