pixman: Branch 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Mar 19 18:10:47 UTC 2020


 pixman/pixman-general.c |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 6fe0131394fb029d2fccaee6b8edcb108840ad8a
Author: Federico Mena Quintero <federico at gnome.org>
Date:   Wed Mar 18 18:49:30 2020 -0600

    Initialize temporary buffers in general_composite_rect()
    
    Otherwise, Valgrind shows things like "conditional jump or move
    depends on uninitialised values" errors much later in calling code.
    For example, see https://gitlab.gnome.org/GNOME/librsvg/issues/572
    
    Fixes https://gitlab.freedesktop.org/pixman/pixman/issues/9

diff --git a/pixman/pixman-general.c b/pixman/pixman-general.c
index 7d74f98..7e5a0d0 100644
--- a/pixman/pixman-general.c
+++ b/pixman/pixman-general.c
@@ -165,6 +165,12 @@ general_composite_rect  (pixman_implementation_t *imp,
 
 	if (!scanline_buffer)
 	    return;
+
+	memset (scanline_buffer, 0, width * Bpp * 3 + 15 * 3);
+    }
+    else
+    {
+	memset (stack_scanline_buffer, 0, sizeof (stack_scanline_buffer));
     }
 
     src_buffer = ALIGN (scanline_buffer);


More information about the xorg-commit mailing list