libICE: Changes to 'master'

[GitLab Mirror]

 src/listenwk.c |    1 +
 src/misc.c     |    1 -
 src/process.c  |    6 ++++--
 3 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit b6aad584c1dc278364c295165512b5f5b98c173e
Author: Olivier Fourdan <ofourdan at redhat.com>
Date:   Thu Apr 11 09:05:15 2019 +0200

    cleanup: Separate variable assignment and test
    
    Assigning and testing a value in a single statement hinders code clarity
    and may confuses static code analyzers.
    
    Separate the assignment and the test for clarity.
    
    Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>

commit 772e5b0fdfc9dbd8bec070bd0c4c7eb5565df2ee
Author: Olivier Fourdan <ofourdan at redhat.com>
Date:   Wed Apr 10 11:15:11 2019 +0200

    _IceRead: Avoid possible use-after-free
    
    `_IceRead()` gets called from multiple places which do not expect the
    connection to be freed.
    
    Do not free the connection data in `_IceRead()` to avoid potential
    use-after-free issue in the various callers.
    
    The connection data will be freed eventually in `ProcessWantToClose()`,
    so not freeing it in `_IceRead()` should not introduce an memory leak.
    
    Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>

commit 1493beba2aa03bdadeed8b4fa5d424df6e113071
Author: Olivier Fourdan <ofourdan at redhat.com>
Date:   Wed Apr 10 11:01:31 2019 +0200

    IceListenForWellKnownConnections: Fix memleak
    
    The function `_IceTransMakeAllCOTSServerListeners` allocates memory for
    `transConns` which is leaked in case of error.
    
    Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>