xserver: Branch 'master'

Peter Hutterer whot at kemper.freedesktop.org
Wed Feb 22 23:18:46 UTC 2017


 os/inputthread.c |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit dcb63deb1b6337781943a7bea5bb2b04c6d76b55
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Feb 22 14:56:28 2017 +0000

    inputthread: Initialise inputThreadInfo->changed before use
    
    ==8734== Thread 2 InputThread:
    ==8734== Conditional jump or move depends on uninitialised value(s)
    ==8734==    at 0x2FDB05: InputThreadDoWork (inputthread.c:333)
    ==8734==    by 0x6924423: start_thread (pthread_create.c:333)
    ==8734==    by 0x6C229BE: clone (clone.S:105)
    
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diff --git a/os/inputthread.c b/os/inputthread.c
index 8e7f2ed..4400fba 100644
--- a/os/inputthread.c
+++ b/os/inputthread.c
@@ -403,6 +403,8 @@ InputThreadPreInit(void)
     if (!inputThreadInfo)
         FatalError("input-thread: could not allocate memory");
 
+    inputThreadInfo->changed = FALSE;
+
     inputThreadInfo->thread = 0;
     xorg_list_init(&inputThreadInfo->devs);
     inputThreadInfo->fds = ospoll_create();


More information about the xorg-commit mailing list