xserver: Changes to 'server-1.19-branch'

Adam Jackson ajax at kemper.freedesktop.org
Tue Dec 13 14:36:47 UTC 2016


New branch 'server-1.19-branch' available with the following commits:
commit d6da2086951693e047fdd22b0d21c539ea1bb1e1
Author: Adam Jackson <ajax at redhat.com>
Date:   Mon Dec 12 13:08:17 2016 -0500

    Revert "damage: Make damageRegionProcessPending take a damage not a drawable"
    
    The commit message makes the assertion that the code below damage is not
    allowed to change whether there's a damage monitor for the drawable.
    That turns out not to be the case! exa's mixed code, at least, will
    create and destroy a damage in PrepareAccess. The destroy path can then
    be catastrophic, as damageRegionProcessPending will attempt to
    RegionEmpty memory from the middle of a freed block.
    
    I'd wanted that invariant for performance, but faster isn't worth
    broken, so revert it. I think what exa's doing is reasonable, so the
    better way to improve performance for the unmonitored case is to either
    revisit dynamically wrapping into the GC, or inline damage into dix.
    
    This reverts commit 4e124203f2260daaf54155f4a05fe469733e0b97.
    
    Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1389886
    Signed-off-by: Adam Jackson <ajax at redhat.com>
    (cherry picked from commit 32e632e85894eddc3ace83f16f1e973b1be478fe)



More information about the xorg-commit mailing list