xcmsdb: Changes to 'master'

[Alan Coopersmith]

 xcmsdb.c |   45 ++++++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 21 deletions(-)

New commits:
commit aa02eb3d4f0c5722b8f9012ec08512daa7420184
Author: Erkki Seppälä <erkki.seppala at vincit.fi>
Date:   Sun Jan 4 12:51:10 2015 -0800

    _XcmsGetProperty: don't deal with uninitialized values, fail instead
    
    Import commit 502d414118c97d35a44f8e295709682022876331 from the
    master copy of this code in libX11.
    
    Signed-off-by: Erkki Seppälä <erkki.seppala at vincit.fi>
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 88135312d0cdfd624dfdd029539959849302a1f4
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Jan 3 14:56:48 2015 -0800

    Only use results from GetWindowProperty if it returned Success
    
    Since Xlib prior to 1.6 didn't always clear values on failure, don't
    assume they're safe to use unless we succeeded.
    
    Reported by Oracle Parfait 1.5.1:
    Error: Uninitialised memory
       Uninitialised memory variable (CWE 457): Possible access to uninitialised memory variable 'ret_format'
            at line 743 of app/xcmsdb/xcmsdb.c in function 'RemoveSCCData'.
              ret_format allocated at line 733.
            at line 757 of app/xcmsdb/xcmsdb.c in function 'RemoveSCCData'.
              ret_format allocated at line 733.
       Uninitialised memory variable (CWE 457): Possible access to uninitialised memory variable 'ret_prop'
            at line 748 of app/xcmsdb/xcmsdb.c in function 'RemoveSCCData'.
              ret_prop allocated at line 731.
            at line 762 of app/xcmsdb/xcmsdb.c in function 'RemoveSCCData'.
              ret_prop allocated at line 731.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Hans de Goede <hdegoede at redhat.com>