transset: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Mon Jan 5 09:41:17 PST 2015


 transSet.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 7c0c3afd6f5bfc02fd98a2da03f7fb7d6567ccf3
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Wed Dec 31 00:24:49 2014 -0800

    Only use property pointer if XGetWindowProperty returns success
    
    In Xlib versions prior to 1.6, if XGetWindowProperty returns a failure,
    it didn't always set the property pointer to NULL, and could leave it
    uninitialized.
    
    Reported by Oracle Parfait 1.5.1:
    Error: Uninitialised memory (CWE 456)
       Possible access to uninitialised memory '&data'
            at line 298 of transSet.c in function 'main'.
              &data allocated at line 154.
            at line 299 of transSet.c in function 'main'.
              &data allocated at line 154.
            at line 300 of transSet.c in function 'main'.
              &data allocated at line 154.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Hans de Goede <hdegoede at redhat.com>



More information about the xorg-commit mailing list