twm: Changes to 'master'
Alan Coopersmith
alanc at kemper.freedesktop.org
Fri Feb 6 19:07:46 PST 2015
src/menus.c | 22 ----------------------
src/parse.c | 19 +++++++++----------
2 files changed, 9 insertions(+), 32 deletions(-)
New commits:
commit 8f68d82c5f6cff9b22dc3335f956453679b207ad
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Wed Dec 31 09:50:11 2014 -0800
Remove custom version of system(3c) for Solaris
Was originally added in 1993 with the comment:
make f.exec do the right thing to get working xterms under Solaris2.
Doesn't seem to be needed any more on modern Solaris.
As a bonus, gets rid of error found by Oracle Parfait 1.5.1 that
if the execl() call fails, the function falls through and returns
an uninitialized value for status and then both parent & child
go back to running the same code.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit 032fc6a734516189e11b43e0b4680d15b62c5e66
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Wed Dec 31 00:49:34 2014 -0800
Only use results from GetWindowProperty if it returned success
Since Xlib prior to 1.6 didn't always clear values on failure, don't
assume they're safe to use unless we succeeded.
Reported by Oracle Parfait 1.5.1:
Error: Uninitialised memory (CWE 456)
Possible access to uninitialised memory '&nPixels'
at line 963 of src/parse.c in function 'put_pixel_on_root'.
&nPixels allocated at line 953.
Possible access to uninitialised memory '&retProp'
at line 962 of src/parse.c in function 'put_pixel_on_root'.
&retProp allocated at line 954.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
More information about the xorg-commit
mailing list