xf86-input-synaptics:synaptics-1.7-branch: 3 commit(s)

Peter Hutterer whot at kemper.freedesktop.org
Thu Sep 4 16:45:26 PDT 2014


Reporting from xf86-input-synaptics: xf86-input-synaptics driver

Please visit:
    http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics
Or get your own copy by using:
    git-clone git://anongit.freedesktop.org/xorg/driver/xf86-input-synaptics

3 commits against synaptics-1.7-branch at 6dee9b3c...:
 conf/50-synaptics.conf |    2 +-
 src/eventcomm.c        |   17 ++++++++++++++---
 src/synaptics.c        |    5 +++--
 3 files changed, 18 insertions(+), 6 deletions(-)


commit 7d958088a354d5a7969448f014f3620b59c7e4da
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Thu Aug 28 14:13:38 2014 +1000

    eventcomm: ensure we're on the same clock as the server
    
    Default on evdev devices is CLOCK_REALTIME. If that clock falls behind the
    server's CLOCK_MONOTONIC, motion after a clickpad click may be delayed by the
    difference in the clocks.
    
    In detail:
    When the timer func is triggered, GetTimeInMillis() which is CLOCK_MONOTONIC,
    is stored as hwState->millis. The eventcomm backend uses struct
    input_event time (CLOCK_REALTIME).
    
    When we read events from the device, if the evdev time is less than the server
    time, the fix for (#48777) sets the current event time to hwState->millis.
    Until the evdev time overtakes that stored time, all events have the
    hwState->millis time.
    
    If during that time a clickpad triggers a physical click,
    clickpad_click_millis is set to hwState->millis + the ignore-motion timeout.
    Thus, all motion is ignored until the event time overtakes that stored
    time.
    
    The whole issue is further enhanced by us unconditionally setting the timer
    func if we get any events, which is a separate issue anyway.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    (cherry-picked from commit 90d19302306f49722e210227b2fb5161e6f51880)

diffstat:
    src/eventcomm.c |   17 ++++++++++++++---
    1 file changed, 14 insertions(+), 3 deletions(-)

cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=7d958088


commit a028ceb894ca3959dd32d83bc8226b5b0b05f9df
Author: Gabriele Mazzotta <gabriele.mzt at gmail.com>
Date:   Sun Jul 27 12:58:18 2014 +0200

    Prevent two-finger taps from being ignored
    
    When two fingers are used, the coordinates of only one of them is taken into
    account. This can lead to sudden variations of the absolute coordinates when
    two-fingers taps are performed if the finger considered changes.
    
    Take into account coordinates variations to prevent unwanted taps only if
    the number of fingers doesn't change.
    
    Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    (cherry picked from commit 7d0ff39519e4d3760722b914883bee276035061c)

diffstat:
    src/synaptics.c |    5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=7d958088


commit e57b219a8c3b70433988f0b894a182cee0ef5736
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Wed Aug 6 12:04:14 2014 +1000

    conf: increase top software button area to 15%
    
    We had reports that the top software button area is hard to hit for those
    using the trackpoint and clicking the buttons with their thumb.
    
    Analysis of event recordings (3 different people) for left, right and middle
    clicks shows that there is a significant amount of events up to about 10mm
    (with outliers up to 12mm) from the top of the touchpad. That maps to 15%.
    
    Interestingly, the middle button does not seem to need this, presumably the
    haptic feedback of the little dots sticking out from the surface make hitting
    the button easier. Its size is increased to 15% anyway, for simplicity and
    because a sample set of 3 is too small to be definitive about this.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Hans de Goede <hdegoede at redhat.com>
    (cherry picked from commit 730101223432f60397c61f74a5e6789b3ee34ecd)

diffstat:
    conf/50-synaptics.conf |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=7d958088




More information about the xorg-commit mailing list