xserver: Branch 'master'

Keith Packard keithp at kemper.freedesktop.org
Mon Jun 23 14:52:07 PDT 2014


 glamor/glamor_vbo.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0d9ad781807022d78239327ed508758a3f88b090
Author: Eric Anholt <eric at anholt.net>
Date:   Mon Jun 16 08:06:53 2014 +0100

    glamor: Fix GLES2 non-VBO temporary memory allocation.
    
    We'd get a request for like 16 bytes, claim to have allocated
    GLAMOR_VBO_SIZE, and then not reallocate when something a request
    bigger than 16 came along.  The intent was to always allocate at least
    GLAMOR_VBO_SIZE.
    
    Fixes segfaults with Xephyr -glamor_gles2 and running gnome-terminal.
    
    Signed-off-by: Eric Anholt <eric at anholt.net>
    Reviewed-by: Keith Packard <keithp at keithp.com>
    Signed-off-by: Keith Packard <keithp at keithp.com>

diff --git a/glamor/glamor_vbo.c b/glamor/glamor_vbo.c
index c678559..e906101 100644
--- a/glamor/glamor_vbo.c
+++ b/glamor/glamor_vbo.c
@@ -119,7 +119,7 @@ glamor_get_vbo_space(ScreenPtr screen, unsigned size, char **vbo_offset)
         if (glamor_priv->vbo_size < size) {
             glamor_priv->vbo_size = MAX(GLAMOR_VBO_SIZE, size);
             free(glamor_priv->vb);
-            glamor_priv->vb = XNFalloc(size);
+            glamor_priv->vb = XNFalloc(glamor_priv->vbo_size);
         }
         *vbo_offset = NULL;
         /* We point to the start of glamor_priv->vb every time, and


More information about the xorg-commit mailing list