bitmap: Changes to 'master'

[Jeremy Huddleston]

 Bitmap.c   |   15 ++++++++-----
 Graphics.c |    8 ++++++-
 atobm.c    |   67 +++++++++++++++++++++++++++++++++++--------------------------
 3 files changed, 55 insertions(+), 35 deletions(-)

New commits:
commit d0911d130b870da0951b56f5103c6b4dfb9eeb28
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date:   Wed Jan 1 23:02:48 2014 -0800

    Use '& 7' instead '% 8' to silence clang analyzer warning
    
    Graphics.c:569:10: warning: The result of the '<<' expression is undefined
            while (!QueryFlood(BW, x, y, value) && (x < x_right))
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    Graphics.c:470:7: note: expanded from macro 'QueryFlood'
        ((GetBit(BW->bitmap.image, x, y) !=\
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Graphics.c:66:9: note: expanded from macro 'GetBit'
                (1 << ((x) % 8))) ? 1 : 0))
                 ~~^~~~~~~~~~~~
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

commit e3fe79502a4a1b0f0b148659948d541ce26ed7bf
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date:   Wed Jan 1 22:58:23 2014 -0800

    Demacro modernization of NewSList to plug a memory leak during error handling
    
    atobm.c:248:6: warning: Potential leak of memory pointed to by 'slist'
                NewSList ();
                ^~~~~~~~~~~
    atobm.c:209:3: note: expanded from macro 'NewSList'
                    fprintf (stderr, "%s:  unable to allocate char array\n", \
                    ^~~~~~~
    atobm.c:259:6: warning: Potential leak of memory pointed to by 'old'
                NewSList ();
                ^~~~~~~~~~~
    atobm.c:209:3: note: expanded from macro 'NewSList'
                    fprintf (stderr, "%s:  unable to allocate char array\n", \
                    ^~~~~~~
    atobm.c:259:6: warning: Potential leak of memory pointed to by 'slist'
                NewSList ();
                ^~~~~~~~~~~
    atobm.c:209:3: note: expanded from macro 'NewSList'
                    fprintf (stderr, "%s:  unable to allocate char array\n", \
                    ^~~~~~~
    3 warnings generated.
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

commit a59538d5d57bd2f8b2101e398a97fe8466b8eef7
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date:   Wed Jan 1 22:43:26 2014 -0800

    Silence -Wbad-function-cast
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

commit e7086abb4576a777a4b0aff8553047077cdd08ce
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date:   Wed Jan 1 22:29:45 2014 -0800

    Avoid shadow declarations
    
    Bitmap.c:906:17: warning: declaration shadows a local variable [-Wshadow]
            unsigned char *image_data;
                           ^
    Bitmap.c:799:11: note: previous declaration is here
        char *image_data, *buffer_data;
              ^
    Bitmap.c:907:8: warning: declaration shadows a local variable [-Wshadow]
            char *buffer_data;
                  ^
    Bitmap.c:799:24: note: previous declaration is here
        char *image_data, *buffer_data;
                           ^
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

commit 1e236565459d10c7ad85ebed285d2acfc4b15b69
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date:   Wed Jan 1 22:27:36 2014 -0800

    assert to avoid a NULL dereference
    
    Bitmap.c:1246:8: warning: Dereference of null pointer
            **str = '\0';
            ~~~~~~^~~~~~
    1 warning generated.
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>