xserver: Branch 'master' - 3 commits

Keith Packard keithp at kemper.freedesktop.org
Tue Apr 29 09:38:16 PDT 2014


 dix/devices.c |    5 -----
 dix/events.c  |    6 ------
 2 files changed, 11 deletions(-)

New commits:
commit 6bd7ad914470322ddd02b50078e159234ebec643
Merge: b92a928 e06fbe4
Author: Keith Packard <keithp at keithp.com>
Date:   Tue Apr 29 09:37:37 2014 -0700

    Merge remote-tracking branch 'whot/for-keith'

commit e06fbe4dc81110e01d36f958849c4ab5f2a9df0e
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Mon Apr 28 07:57:00 2014 +1000

    dix: remove a now-superfluous comment
    
    Obsolete since 93945b0a74aa8156a88f52b8ba77f1210042f396
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diff --git a/dix/events.c b/dix/events.c
index 125a0ee..7e7a1c9 100644
--- a/dix/events.c
+++ b/dix/events.c
@@ -4260,12 +4260,6 @@ DeliverGrabbedEvent(InternalEvent *event, DeviceIntPtr thisDev,
                                              thisDev);
     }
     if (!deliveries) {
-        /* XXX: In theory, we could pass the internal events through to
-         * everything and only convert just before hitting the wire. We can't
-         * do that yet, so DGE is the last stop for internal events. From here
-         * onwards, we deal with core/XI events.
-         */
-
         sendCore = (IsMaster(thisDev) && thisDev->coreEvents);
         /* try core event */
         if ((sendCore && grab->grabtype == CORE) || grab->grabtype != CORE)
commit 6a848122def0f2a439e21c50f22814db11760132
Author: Michal Srb <msrb at suse.com>
Date:   Wed Apr 2 17:14:05 2014 +0300

    input: Remove invalid bug checks.
    
    Commit 2f1aedcaed8fd99b823d451bf1fb02330c078f67 added several bug checks. Some
    of them are not correct.
    
    Checks in Init(Ptr|String|Bell|Led|Integer)FeedbackClassDeviceStruct verify
    that no feedback struct was set yet, but that is not required. If any feedback
    structs are already present, the function will chain them behind the new one.
    
    Signed-off-by: Michal Srb <msrb at suse.com>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diff --git a/dix/devices.c b/dix/devices.c
index ab923d5..73f60f4 100644
--- a/dix/devices.c
+++ b/dix/devices.c
@@ -1475,7 +1475,6 @@ InitPtrFeedbackClassDeviceStruct(DeviceIntPtr dev, PtrCtrlProcPtr controlProc)
     PtrFeedbackPtr feedc;
 
     BUG_RETURN_VAL(dev == NULL, FALSE);
-    BUG_RETURN_VAL(dev->ptrfeed != NULL, FALSE);
 
     feedc = malloc(sizeof(PtrFeedbackClassRec));
     if (!feedc)
@@ -1519,7 +1518,6 @@ InitStringFeedbackClassDeviceStruct(DeviceIntPtr dev,
     StringFeedbackPtr feedc;
 
     BUG_RETURN_VAL(dev == NULL, FALSE);
-    BUG_RETURN_VAL(dev->stringfeed != NULL, FALSE);
 
     feedc = malloc(sizeof(StringFeedbackClassRec));
     if (!feedc)
@@ -1556,7 +1554,6 @@ InitBellFeedbackClassDeviceStruct(DeviceIntPtr dev, BellProcPtr bellProc,
     BellFeedbackPtr feedc;
 
     BUG_RETURN_VAL(dev == NULL, FALSE);
-    BUG_RETURN_VAL(dev->bell != NULL, FALSE);
 
     feedc = malloc(sizeof(BellFeedbackClassRec));
     if (!feedc)
@@ -1578,7 +1575,6 @@ InitLedFeedbackClassDeviceStruct(DeviceIntPtr dev, LedCtrlProcPtr controlProc)
     LedFeedbackPtr feedc;
 
     BUG_RETURN_VAL(dev == NULL, FALSE);
-    BUG_RETURN_VAL(dev->leds != NULL, FALSE);
 
     feedc = malloc(sizeof(LedFeedbackClassRec));
     if (!feedc)
@@ -1601,7 +1597,6 @@ InitIntegerFeedbackClassDeviceStruct(DeviceIntPtr dev,
     IntegerFeedbackPtr feedc;
 
     BUG_RETURN_VAL(dev == NULL, FALSE);
-    BUG_RETURN_VAL(dev->intfeed != NULL, FALSE);
 
     feedc = malloc(sizeof(IntegerFeedbackClassRec));
     if (!feedc)


More information about the xorg-commit mailing list