xserver: Branch 'master'

Keith Packard keithp at kemper.freedesktop.org
Mon Apr 21 22:06:06 PDT 2014


 os/busfault.c |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 35d275c7519570ceaf82cd5e7a663a8a5be4d441
Author: Eric Anholt <eric at anholt.net>
Date:   Fri Apr 4 08:38:33 2014 +0100

    os: Initialize the set of signals to be suppressed during our handler.
    
    Fixes a valgrind complaint:
    
    ==8805== Syscall param rt_sigaction(act->sa_mask) points to uninitialised byte(s)
    ==8805==    at 0x5EB8315: __libc_sigaction (sigaction.c:66)
    ==8805==    by 0x5B13DA: busfault_init (busfault.c:145)
    ==8805==    by 0x5A60A2: OsInit (osinit.c:191)
    ==8805==    by 0x46EBA2: dix_main (main.c:163)
    
    Signed-off-by: Eric Anholt <eric at anholt.net>
    Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Signed-off-by: Keith Packard <keithp at keithp.com>

diff --git a/os/busfault.c b/os/busfault.c
index 43bb6ea..ac0268f 100644
--- a/os/busfault.c
+++ b/os/busfault.c
@@ -142,6 +142,7 @@ busfault_init(void)
 
     act.sa_sigaction = busfault_sigaction;
     act.sa_flags = SA_SIGINFO;
+    sigemptyset(&act.sa_mask);
     if (sigaction(SIGBUS, &act, &old_act) < 0)
         return FALSE;
     previous_busfault_sigaction = old_act.sa_sigaction;


More information about the xorg-commit mailing list