xf86-input-synaptics:synaptics-1.7-branch: 3 commit(s)

[Peter Hutterer]

Reporting from xf86-input-synaptics: xf86-input-synaptics driver

Please visit:
    http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics
Or get your own copy by using:
    git-clone git://anongit.freedesktop.org/xorg/driver/xf86-input-synaptics

3 commits against synaptics-1.7-branch at 8a5533aa...:
 src/eventcomm.c |   39 +++++++++++++++++++++++++++++++++++----
 1 file changed, 35 insertions(+), 4 deletions(-)


commit bbaf4d646ebf4393a1ee0eb9bcc569054ed878f9
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Thu Mar 20 11:51:17 2014 +1000

    Avoid erroneously handling two touchpoints in the same slot
    
    If a slot's ABS_MT_TRACKING_ID event was received during SYN_DROPPED, the
    driver isn't aware that a touchpoint has started or ended in that slot. When
    the next ABS_MT_TRACKING_ID event arrives, the driver would unconditionally
    close or open a new touchpoint. This could lead to two or more touchpoints
    being opened in the same slot, the first of which is never terminated.
    Or it could lead to a touchpoint being terminated that was never opened.
    
    The event sequences that trigger this are:
        ABS_MT_TRACKING_ID 83
        ABS_MT_TRACKING_ID -1
        SYN_DROPPED             // new touchpoint started here
        ABS_MT_TRACKING_ID -1
    
    and
    
        ABS_MT_TRACKING_ID 83
        SYN_DROPPED             // touchpoint ended here
        ABS_MT_TRACKING_ID 84
        ABS_MT_TRACKING_ID -1
    
    We don't properly handle SYN_DROPPED, but we can avoid this by only starting a
    new touchpoint when we transition between -1 and a valid tracking ID.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    src/eventcomm.c |   34 +++++++++++++++++++++++++++++++++-
    1 file changed, 33 insertions(+), 1 deletion(-)

cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=bbaf4d64


commit a21b3bd602b31ee995b391a7b917282e7b0a1c33
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Thu Mar 20 10:58:53 2014 +1000

    eventcomm: drop assumption of non-zero slot offset
    
    The kernel guarantees this is always 0
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    src/eventcomm.c |    3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=bbaf4d64


commit 91cc1e82143b939bfb4fce97429b07105333e146
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Mon Mar 10 16:42:34 2014 +1000

    eventcomm: drop calculation of slot offset
    
    The kernel guarantees slots start at 0
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Hans de Goede <hdegoede at redhat.com>
    Reviewed-by: Benjamin Tissoires <benjamin.tissoires at gmail.com>
    (cherry picked from commit 5b7e1726369d4973859996f225bec743c2e21288)

diffstat:
    src/eventcomm.c |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=bbaf4d64