xkill: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Fri Sep 6 00:18:22 PDT 2013


 configure.ac |    2 +-
 xkill.c      |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1b8bf0b5477c1f6ad38a7d57cd9ef354409472d1
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri Sep 6 00:15:23 2013 -0700

    Explicitly cast tolower() return value to char before storing in a char
    
    For ancient historical compatibility, the C standards define the
    <ctype.h> functions as taking & returning ints, but limiting them
    to the subset of values that fit in a char.
    
    Silences clang warning:
    xkill.c:244:12: warning: implicit conversion loses integer precision: 'int' to
          'char' [-Wconversion]
                *cp = _tolower (*cp);
                    ~ ^~~~~~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 1519db19e3d1ed1efc07c8c428c1e9013d93f285
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri Sep 6 00:13:44 2013 -0700

    Mark arguments to catch_window_errors as unused
    
    Arguments are required by the callback form, but not needed in this case.
    
    Clears clang compliants:
    xkill.c:328:30: warning: unused parameter 'dpy' [-Wunused-parameter]
    catch_window_errors(Display *dpy, XErrorEvent *ev)
                                 ^
    xkill.c:328:48: warning: unused parameter 'ev' [-Wunused-parameter]
    catch_window_errors(Display *dpy, XErrorEvent *ev)
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>



More information about the xorg-commit mailing list