libX11: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Sun Jul 21 11:07:15 PDT 2013


 src/Font.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6d926088d80a08e13e6d6c4ff207b81ad52e667f
Author: Thomas Klausner <wiz at NetBSD.org>
Date:   Tue Jun 25 18:34:32 2013 +0200

    Fix out-of-range comparison in _XF86BigfontQueryFont
    
    clang complained (correctly):
    warning: comparison of constant 768614336404564650 with expression
    of type 'CARD32' (aka 'unsigned int') is always true
    [-Wtautological-constant-out-of-range-compare]
    
    [While LONG_MAX is correct, since it's used in size_t math, the
     numbers have to be limited to 32-bit range to be usable by 32-bit
     clients, and values beyond that range are far more likely to be
     bugs in the data from the server than valid numbers of characters
     in a font.   -alan- ]
    
    Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>



More information about the xorg-commit mailing list