xf86-video-intel: src/sna/gen7_render.c

Chris Wilson ickle at kemper.freedesktop.org
Tue Jan 22 01:10:57 PST 2013


 src/sna/gen7_render.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c8817e24a9d97110a961c3803290e38ff5cbfc9a
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jan 22 09:06:50 2013 +0000

    sna/gen7: Fix inversion of bool return code from CA pass
    
    As we inverted the predicate, we no longer restored the original
    operation after performing a CA pass - glyph would randomly become
    white.
    
    Reported-by: Jiri Slaby<jirislaby at gmail.com>
    References: https://bugs.freedesktop.org/show_bug.cgi?id=47597
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/sna/gen7_render.c b/src/sna/gen7_render.c
index 158c92e..0766075 100644
--- a/src/sna/gen7_render.c
+++ b/src/sna/gen7_render.c
@@ -1040,7 +1040,7 @@ static bool gen7_magic_ca_pass(struct sna *sna,
 	struct gen7_render_state *state = &sna->render_state.gen7;
 
 	if (!op->need_magic_ca_pass)
-		return true;
+		return false;
 
 	DBG(("%s: CA fixup (%d -> %d)\n", __FUNCTION__,
 	     sna->render.vertex_start, sna->render.vertex_index));
@@ -1064,7 +1064,7 @@ static bool gen7_magic_ca_pass(struct sna *sna,
 	OUT_BATCH(0);	/* index buffer offset, ignored */
 
 	state->last_primitive = sna->kgem.nbatch;
-	return false;
+	return true;
 }
 
 static void null_create(struct sna_static_stream *stream)


More information about the xorg-commit mailing list