xf86-video-intel: src/sna/kgem.c

Chris Wilson ickle at kemper.freedesktop.org
Fri Feb 1 10:27:27 PST 2013


 src/sna/kgem.c |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 9807bba950078d86a25b91064ecfebaa0ee459e3
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Feb 1 18:25:48 2013 +0000

    sna: Drop bogus refcnt assertion during kgem_bo_retire()
    
    As we may call it kgem_bo_sync(), during preparation of the upload
    buffer which in turn may operate on an object straight out of the snoop
    cache and hence not yet referenced (or in some cases, ever).
    
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/sna/kgem.c b/src/sna/kgem.c
index c050a52..36b245d 100644
--- a/src/sna/kgem.c
+++ b/src/sna/kgem.c
@@ -394,7 +394,6 @@ static void kgem_bo_retire(struct kgem *kgem, struct kgem_bo *bo)
 	DBG(("%s: retiring bo handle=%d (needed flush? %d), rq? %d [busy?=%d]\n",
 	     __FUNCTION__, bo->handle, bo->needs_flush, bo->rq != NULL,
 	     __kgem_busy(kgem, bo->handle)));
-	assert(bo->refcnt);
 	assert(bo->exec == NULL);
 	assert(list_is_empty(&bo->vma));
 


More information about the xorg-commit mailing list