xman: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Thu Apr 25 21:41:58 PDT 2013


 buttons.c    |    2 
 configure.ac |    8 +-
 defs.h       |    4 +
 handler.c    |   18 ++--
 help.c       |    2 
 man.h        |    8 ++
 misc.c       |  219 +++++++++++++++++++++--------------------------------------
 search.c     |   10 --
 vendor.h     |   38 ++--------
 9 files changed, 118 insertions(+), 191 deletions(-)

New commits:
commit cf05d354a937e234f60d90c36c7bd676c521b548
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Apr 21 13:11:23 2013 -0700

    Check for CreateManpage returning NULL
    
    Now that it can propogate the malloc failure on from InitPsuedoGlobals,
    we need to check its result before using it as well.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 4d31718584028d9f3df144d54269c4b62a8b5bb5
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Apr 21 13:08:38 2013 -0700

    Check for InitPsuedoGlobals() returning NULL
    
    Fixes possible NULL pointer dereferences warned about by parfait:
    
       Read from null pointer 'man_globals'
            at line 162 of buttons.c in function 'CreateManpage'.
              Function 'InitPsuedoGlobals' may return constant 'NULL' at line 183, called at line 153.
              Null pointer introduced at line 183 in function 'InitPsuedoGlobals'.
       Read from null pointer 'man_globals'
            at line 59 of help.c in function 'MakeHelpWidget'.
              Function 'InitPsuedoGlobals' may return constant 'NULL' at line 185, called at line 56.
              Null pointer introduced at line 183 of buttons.c in function 'InitPsuedoGlobals'.
    
    and various ones following from each path from those points.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit e34e8c6d3203cfeed0f98aae504f318a26d5d75b
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Apr 21 11:29:59 2013 -0700

    Close file pointer before setting it to NULL in Format()
    
    Avoids more file leaks
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 58b857bcc005552b1ae90733c52d456dc56c3f9b
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Apr 21 10:36:41 2013 -0700

    Fix file leak in ConstructCommand()
    
    File was never closed in any code path.
    
    Found by parfait 1.1 bug checking tool:
    Error: File Leak
       File Leak: Leaked File file
            at line 729 of misc.c in function 'ConstructCommand'.
              file initialized at line 703 with fopen
              file leaks when fopen(fname, "r") != NULL at line 703.
            at line 771 of misc.c in function 'ConstructCommand'.
              file initialized at line 703 with fopen
              file leaks when fopen(fname, "r") != NULL at line 703.
            at line 773 of misc.c in function 'ConstructCommand'.
              file initialized at line 703 with fopen
              file leaks when fopen(fname, "r") != NULL at line 703.
            at line 763 of misc.c in function 'ConstructCommand'.
              file initialized at line 703 with fopen
              file leaks when fopen(fname, "r") != NULL at line 703
                  and left <= 1 at line 762.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit d25a3b87ce9fdf950b42f45b644242d72e7167b3
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Apr 20 09:56:08 2013 -0700

    configure: check for groff and enable groff extensions if found
    
    Check for groff never got translated from imake to autoconf
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

commit 72b3760a2a5c4ea81c3bebf085b3b8f5ac56730e
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Apr 20 08:58:46 2013 -0700

    Provide a fallback mkstemp so we don't need to maintain 2 API versions
    
    Unifies the file handling API's to always return an open fd or FILE *,
    instead of delaying the open when mkstemp was not available.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>



More information about the xorg-commit mailing list