xf86-video-intel: src/sna/sna_video_overlay.c

Chris Wilson ickle at kemper.freedesktop.org
Tue May 29 14:23:16 PDT 2012


 src/sna/sna_video_overlay.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e986b06162abf286b3f8f97b791fd66dcf8f9aec
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue May 29 22:21:05 2012 +0100

    sna/overlay: Handle return from GETPARAM query correctly
    
    drmIoctl() returns 0 on success, not a positive value.
    
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/sna/sna_video_overlay.c b/src/sna/sna_video_overlay.c
index c39bbfc..945818a 100644
--- a/src/sna/sna_video_overlay.c
+++ b/src/sna/sna_video_overlay.c
@@ -114,7 +114,7 @@ static Bool sna_has_overlay(struct sna *sna)
 	gp.param = I915_PARAM_HAS_OVERLAY;
 	gp.value = &has_overlay;
 	ret = drmIoctl(sna->kgem.fd, DRM_IOCTL_I915_GETPARAM, &gp);
-	return ret > 0 && has_overlay;
+	return ret == 0 && has_overlay;
 }
 
 static Bool sna_video_overlay_update_attrs(struct sna *sna,


More information about the xorg-commit mailing list