xf86-input-synaptics:master: 4 commit(s)
Peter Hutterer
whot at kemper.freedesktop.org
Thu May 17 16:14:59 PDT 2012
Reporting from xf86-input-synaptics: xf86-input-synaptics driver
Please visit:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics
Or get your own copy by using:
git-clone git://anongit.freedesktop.org/xorg/driver/xf86-input-synaptics
4 commits against master at 53557a5c...:
src/properties.c | 6 ++++++
src/synaptics.c | 48 +++++++++++++++++++-----------------------------
src/synapticsstr.h | 1 -
src/synproto.c | 4 ++--
4 files changed, 27 insertions(+), 32 deletions(-)
commit a9d247d076b3d0d1df84f013b3733bd6297dd79b
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date: Thu May 17 15:52:50 2012 +1000
Remove absolute mode
Moving a touchpad in absolute mode is unusual - touchpads are disconnected
from the output device, so direct interaction is hard. There appears to be
little usage of it (I haven't seen bug reports from people claiming to use
it). Joe Shaw, author of the code and only known user doesn't have a use for
it anymore, so purge it from the repo.
Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
diffstat:
src/synaptics.c | 34 +++++-----------------------------
src/synapticsstr.h | 1 -
2 files changed, 5 insertions(+), 30 deletions(-)
cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=a9d247d0
commit 6d47d334d8a876e7e094306c313246b87016b78a
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date: Thu May 17 12:10:04 2012 +1000
Don't allow for scroll distances of 0 (#49965)
It'll either hang the server or blow up with divisions by 0, whichever one
comes first.
X.Org Bug 49965 <http://bugs.freedesktop.org/show_bug.cgi?id=49965>
Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
diffstat:
src/properties.c | 6 ++++++
1 file changed, 6 insertions(+)
cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=a9d247d0
commit cd569377cda9b5a4ee00c0137db14f625c76c40f
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date: Thu May 17 11:02:02 2012 +1000
Reset hw->x/y to INT_MIN and skip HandleState until we have x/y events
The driver assumes x/y is always valid but after coming from a resume we may
get a few events with either ABS_X or ABS_Y (not both). Thus we process with
hw->x == 0 and hw->y == somevalue, causing cursor jumps when calculating
deltas whenver the real hw->x comes in.
Fix this by resetting hw->x/y to INT_MIN and skip state processing until
both axes are available.
For clickpads, this means handling of data will be delayed until we get
at least one motion on each axis. Button presses won't be recognised either
until that happens. It requires some skill to not trigger motion on both
axes, even more to press a button without doing so.
For non-clickpads, handling of motion events will be delayed likewise. If a
physical button is pressed immediately after resume we have to assume deltas
of x/y.
- If the next event is a new touch, it will have ABS_X/ABS_Y set anyway
- If the finger was already down, a button event is generated, and the
finger has generated ABS_X or ABS_Y only before the event, the next event
containing the missing data will cause a jump. The fix for this is more
invasive and this is quite a corner-case.
Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
diffstat:
src/synaptics.c | 13 +++++++++++++
src/synproto.c | 4 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=a9d247d0
commit 0054b144f3daf00e46a35b2f165befb209df94fc
Author: Chase Douglas <chase.douglas at canonical.com>
Date: Wed May 16 07:49:25 2012 -0700
Reset open slots array on device disable
The open slots array is used for clickpad cumulative delta computation.
If the array is not reset and becomes corrupted during the device
disable/enable cycle, the cumulative deltas may be wrong. This manifests
as jumpy cursor behavior on some clickpads after suspend/resume.
Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
diffstat:
src/synaptics.c | 1 +
1 file changed, 1 insertion(+)
cgit url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=a9d247d0
More information about the xorg-commit
mailing list