xsm: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Wed Nov 30 18:57:23 PST 2011


 lock.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c358556c1badee4d8b75e23f1cd84abff393b6ac
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Tue Nov 22 22:58:52 2011 -0800

    Add size limit to scanf string specifier
    
    While it's tempting to just switch to fgets(), that would require
    implementing our own whitespace stripping to match the current
    scanf behavior.
    
    Fixes parfait static analysis warning:
    Error: Buffer overrun
       Buffer overflow (CWE 120): Use of fscanf(%s), with buffer 'buf'
            at line 135 of app/xsm/lock.c in function 'GetLockId'.
    
    [ This bug was found by the Parfait 0.3.7 bug checking tool.
      For more information see http://labs.oracle.com/projects/parfait/ ]
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>



More information about the xorg-commit mailing list