xf86-video-intel: src/i965_video.c

[Chris Wilson]

On Mon, 14 Nov 2011 09:11:34 -0800, Eric Anholt <eric at anholt.net> wrote:
> On Mon, 14 Nov 2011 00:49:09 -0800 (PST), ickle at kemper.freedesktop.org (Chris Wilson) wrote:
> >  src/i965_video.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > New commits:
> > commit 1baff9f8cf79fdb4a5649eabcc66cf73487c873e
> > Author: Chris Wilson <chris at chris-wilson.co.uk>
> > Date:   Mon Nov 14 08:44:35 2011 +0000
> > 
> >     uxa/gen4+: Re-emit composite invariant after video
> >     
> >     Reported-by: Ben Hutchings <ben at decadent.org.uk>
> >     Bugzilla: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635953
> >     Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Huh?  The point of it being "invariant" was that it was invariant across
> the batchbuffer.  Is some code in invariant that shouldn't be any more?

We just have two bits of code (video/render) assuming that their state is
invariant. The straw that broke the camel's back is the use of
surface relocations in STATE_BASE_ADDRESS. The larger patch is to unify
the two 3D pipelines into a shared state tracker, which will naturally
be addressed by glamor.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre