xdm: Changes to 'master'

[Alan Coopersmith]

 chooser/chooser.c |   21 +++++++++---------
 configure.ac      |    2 -
 xdm/access.c      |   37 ++++++++++++++-------------------
 xdm/auth.c        |   28 ++++++++++---------------
 xdm/choose.c      |   16 +++++++-------
 xdm/dm.c          |    3 --
 xdm/dpylist.c     |   60 ++++++++++++++++++++++++++----------------------------
 xdm/file.c        |   11 ++++-----
 xdm/krb5auth.c    |   16 ++++++--------
 xdm/mitauth.c     |   18 ++++++++--------
 xdm/policy.c      |    2 -
 xdm/protodpy.c    |   14 ++++++------
 xdm/resource.c    |    2 -
 xdm/rpcauth.c     |   12 +++++-----
 xdm/server.c      |    5 +---
 xdm/session.c     |    2 -
 xdm/socket.c      |    3 --
 xdm/util.c        |   16 +++++++-------
 xdm/xdmauth.c     |   28 +++++++++++--------------
 xdm/xdmcp.c       |   16 +++++++-------
 20 files changed, 145 insertions(+), 167 deletions(-)

New commits:
commit 1953570d9cd7c4e57fc270e6146aa13e794be0de
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat May 14 10:52:18 2011 -0700

    Only greeter needs XPM CFLAGS & LIBS, not xdm daemon
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net>
    Reviewed-by: Julien Cristau <jcristau at debian.org>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
    Acked-by: Gaetan Nadon <memsize at videotron.ca>

commit 47c1b146c786f057026ea2ad89b8cb4c51ee3d50
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat May 14 10:44:06 2011 -0700

    Stop casting return values of malloc and friends
    
    It's not needed on modern mallocs that return void *, and can hide
    missing prototype errors that cause the compiler to assume int is
    returned (a bad thing to assume in 64-bit builds).
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net>
    Reviewed-by: Julien Cristau <jcristau at debian.org>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
    Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

commit f29b73ba549fbdcbe1361c016fc40cc424c32e9b
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat May 14 10:33:50 2011 -0700

    Stop casting free() arguments to (char *)
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net>
    Reviewed-by: Julien Cristau <jcristau at debian.org>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
    Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

commit 6cb6fcd3a95bc125615d4a6736712bcc45ad7685
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat May 14 10:24:06 2011 -0700

    Stop checking for NULL before calling free()
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net>
    Reviewed-by: Julien Cristau <jcristau at debian.org>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
    Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

commit d39dbde390f0f609c03dbd79f0bcc6a3486ca8a3
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat May 14 09:29:30 2011 -0700

    Fix potential memory leak in allocation failure cleanup path
    
    Error: Memory leak (CWE 401)
       Memory leak of pointer 'newargv' allocated with realloc(((i8*)argv), ((i * 4) + 8))
            at line 239 of /export/alanc/X.Org/git/app/xdm/xdm/util.c in function 'parseArgs'.
              'newargv' allocated at line 231 with realloc(((i8*)argv), ((i * 4) + 8)).
              newargv leaks when newargv != 0 at line 234
                  and save == 0 at line 234.
    
    [This bug was found by the Parfait 0.3.7 bug checking tool.
     For more information see http://labs.oracle.com/projects/parfait/ ]
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net>
    Reviewed-by: Julien Cristau <jcristau at debian.org>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>