twm: Changes to 'master'

Jeremy Huddleston jeremyhu at kemper.freedesktop.org
Thu May 12 19:04:04 PDT 2011


 src/menus.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 70a7f34dfc4d7ea4f7425b9a7359a08a35752bb0
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date:   Wed May 11 22:41:56 2011 -0700

    Add extra sanity checking to avoid possible NULL dereferences
    
    menus.c:569:10: warning: Access to field 'func' results in a dereference of a null pointer (loaded from variable 'ActiveItem')
                if (ActiveItem->func != F_TITLE && !ActiveItem->state)
                    ^~~~~~~~~~
    
    Found-by: clang static analyzer
    Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
    Acked-by: Peter Hutterer <peter.hutterer at who-t.net>

commit a898b136729660a33d60b317ccb839f6e0428201
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date:   Wed May 11 22:30:56 2011 -0700

    Add sanity checking to avoid a possible NULL dereference
    
    menus.c:934:26: warning: Access to field 'fore' results in a dereference of a null pointer (loaded from variable 'cur')
                cur->hi_back = cur->fore = f3.pixel;
                               ~~~  ^
    
    Found-by: clang static analyzer
    Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
    Acked-by: Peter Hutterer <peter.hutterer at who-t.net>

commit 1061e063be78f4e233d550649ce297b639193a9f
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date:   Wed May 11 22:27:21 2011 -0700

    Address a possible NULL pointer dereference
    
    menus.c:523:24: warning: Access to field 'w' results in a dereference of a null pointer (loaded from variable 'ActiveMenu')
            if (XFindContext(dpy, ActiveMenu->w, ScreenContext, &context_data) == 0)
                                  ^~~~~~~~~~
    
    Found-by: clang static analyzer
    Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
    Acked-by: Peter Hutterer <peter.hutterer at who-t.net>



More information about the xorg-commit mailing list