xprop: Changes to 'master'

Jeremy Huddleston jeremyhu at kemper.freedesktop.org
Sun May 8 21:48:28 PDT 2011


 xprop.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 66240b78d9ee8d4bbdfb3a5ccf9d87058cddf0de
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date:   Sun May 8 21:47:06 2011 -0700

    Make error handlint more robust in Format_Len_Unicode
    
    xprop.c:1011:2: warning: Function call argument is an uninitialized value
            memcpy(_formatting_buffer, error, strlen(error)+1);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    xprop.c:1011:36: note: instantiated from:
            memcpy(_formatting_buffer, error, strlen(error)+1);
                                              ^      ~~~~~
    
    Found-by: clang static analysis
    Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>

commit 433f43ec71447c447cdc6142ab5829a8eea258a7
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date:   Sun May 8 17:12:04 2011 -0700

    Fix uninitialize values warnings in static analysis
    
    xprop.c:299:25: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'thunk_count')
        _property_formats = Add_Thunk(_property_formats, t);
                            ^                            ~
    xprop.c:1394:11: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'thunk_count')
            thunks = Add_Thunk(thunks, t);
                     ^                 ~
    xprop.c:1581:15: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'thunk_count')
                thunks = Add_Thunk(thunks, t);
                         ^                 ~
    xprop.c:1962:18: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'thunk_count')
                set_props = Add_Thunk(set_props, t);
                            ^                    ~
    xprop.c:1952:21: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'thunk_count')
                remove_props = Add_Thunk(remove_props, t);
                               ^                       ~
    
    Found-by: clang static analyzer
    Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>



More information about the xorg-commit mailing list