xrandr: Changes to 'master'
Jeremy Huddleston
jeremyhu at kemper.freedesktop.org
Sun May 8 16:49:33 PDT 2011
configure.ac | 2 +-
xrandr.c | 13 +++++--------
2 files changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 30e9137bf94f58f66cc6883b0a47eab3159c8be6
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date: Sun May 8 16:42:50 2011 -0700
Dead code removal
xrandr.c:2978:33: warning: Value stored to 'first' is never read
if (!first) printf (" "); first = False;
^ ~~~~~
xrandr.c:2966:30: warning: Value stored to 'first' is never read
if (!first) printf (" "); first = False;
^ ~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
commit 1e48aad532aa19a35efbee24cddca4c43e02afe7
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date: Sun May 8 16:35:47 2011 -0700
Dead code removal
Removing the redundant setting of format = 32 in the XA_ATOM case.
It was already set to that earlier whe it was assigned actual_format.
xrandr.c:2770:3: warning: Value stored to 'format' is never read
format=0;
^ ~
xrandr.c:2782:7: warning: Value stored to 'format' is never read
format = actual_format;
^ ~~~~~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
commit dd2a2e7dc918c57aae3df57118042e4362377243
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date: Sun May 8 16:29:51 2011 -0700
Mark usage, fatal, and panic as _X_NORETURN
xrandr.c:634:13: warning: Access to field 'next' results in a dereference of a null pointer (loaded from variable 'output')
output->next = NULL;
~~~~~~ ^
xrandr.c:1214:6: warning: Access to field 'mode' results in a dereference of a null pointer (loaded from variable 'crtc_info')
if (crtc_info->mode == None)
^~~~~~~~~
xrandr.c:1252:5: warning: Array access (via field 'outputs') results in a null pointer dereference
crtc->outputs[crtc->noutput++] = output;
^ ~~~~~~~
xrandr.c:1638:33: warning: Access to field 'name' results in a dereference of a null pointer (loaded from variable 'output_info')
set_name_string (&output_name, output_info->name);
^~~~~~~~~~~
xrandr.c:1725:10: warning: Access to field 'changes' results in a dereference of a null pointer (loaded from variable 'output')
if (output->changes)
^~~~~~
xrandr.c:1848:10: warning: Access to field 'mode_info' results in a dereference of a null pointer (loaded from variable 'relation')
if (relation->mode_info == NULL)
^~~~~~~~
xrandr.c:3194:11: warning: Array access (from variable 'mode_shown') results in a null pointer dereference
if (mode_shown[j]) continue;
^~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
More information about the xorg-commit
mailing list