libX11: Changes to 'master'

Jamey Sharp jamey at kemper.freedesktop.org
Tue Mar 15 16:57:08 PDT 2011


 src/XlibInt.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 83e1ba59c48c79f8b0a7e7aa0b9c9cfd84fa403d
Author: Jamey Sharp <jamey at minilop.net>
Date:   Tue Mar 15 16:48:07 2011 -0700

    Call _XErrorFunction without holding the Display lock.
    
    Historically, Xlib dropped the Display lock around the upcall to any
    user-supplied _XErrorFunction, but somewhere along the way I quit doing
    that if you built with XCB. The reasons are lost somewhere in the
    pre-git history of Xlib/XCB, and I can't now see any reason to hold the
    lock.
    
    The documentation for XSetErrorHandler still applies though:
    
        Because this condition is not assumed to be fatal, it is acceptable
        for your error handler to return; the returned value is ignored.
        However, the error handler should not call any functions (directly
        or indirectly) on the display that will generate protocol requests
        or that will look for input events.
    
    So while you are now once again permitted to re-enter Xlib from the
    error handler, you're only allowed to call non-protocol functions.
    
    Signed-off-by: Jamey Sharp <jamey at minilop.net>



More information about the xorg-commit mailing list