mkfontscale: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Tue Mar 1 19:18:34 PST 2011


 list.c        |    4 +++-
 mkfontscale.c |    2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit b8c26cb3d41b18dfcc14a1ae256f6575c7df7593
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Feb 24 23:24:17 2011 -0800

    makeList: free partially allocated list on failure
    
    Error: Memory leak (CWE 401)
       Memory leak of pointer 'first' allocated with malloc(8)
            at line 192 of list.c in function 'makeList'.
              'first' allocated at line 181 with malloc(8).
              first leaks when next == 0 at line 191.
    
    [ This bug was found by the Parfait 0.3.6 bug checking tool.
      For more information see http://labs.oracle.com/projects/parfait/ ]
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Julien Cristau <jcristau at debian.org>

commit 9d424d79ca56e7e372a286fca478996eeee8ebfe
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Feb 24 23:15:25 2011 -0800

    Leave room for null terminator in file & font name arrays
    
    fscanf %s arguments don't include the trailing \0 byte in their counts.
    
    Error: Buffer overrun
       Buffer overflow (CWE 120): Use of fscanf(%1024[), with buffer 'font'
          Array size is 1024 bytes
            at line 707 of mkfontscale.c in function 'readFontScale'.
       Buffer overflow (CWE 120): Use of fscanf(%1024s), with buffer 'file'
          Array size is 1024 bytes
            at line 707 of mkfontscale.c in function 'readFontScale'.
    
    [ This bug was found by the Parfait 0.3.6 bug checking tool.
      For more information see http://labs.oracle.com/projects/parfait/ ]
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Julien Cristau <jcristau at debian.org>



More information about the xorg-commit mailing list