xdm: Changes to 'master'

[Alan Coopersmith]

 greeter/Login.c    |    8 ++---
 greeter/greet.c    |   80 +++++++++++++++++++++++++++++++++--------------------
 include/dm_error.h |   18 +++--------
 xdm/error.c        |    2 -
 4 files changed, 62 insertions(+), 46 deletions(-)

New commits:
commit 5574b79c2d6c89f96484b890872ba1594fb6ddd2
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jun 2 21:52:20 2011 -0700

    Simplify FailedLogin code
    
    Relies on username going out of scope to discard the pointer returned by
    pam_get_item that pam_end frees at the bottom of the loop.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

commit 29e9393697d0b7158c2c1e0856180713c7c8f925
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jun 2 21:39:16 2011 -0700

    Stop using username retrieved from PAM before pam_end frees it.
    
    The first time a failed login message was syslogged it had the right
    username, but subsequent ones kept reusing that pointer, even though
    PAM had freed it and it may have been reused and filled with something
    else, resulting in garbage user names for the later login failures.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

commit eca379146cf487cbd05e1698ea12c1835327d1d4
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jun 2 20:46:57 2011 -0700

    Add _X_ATTRIBUTE_PRINTF to LogVWrite declaration
    
    Suggested by gcc -Wmissing-format-attribute
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

commit 7b8a4bb753d9da4cde60379050493d811c9b3044
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jun 2 20:45:32 2011 -0700

    Replace GCC_PRINTFLIKE with xproto's _X_ATTRIBUTE_PRINTF
    
    The existing GCC_PRINTFLIKE declaration seems to have been broken, since
    it only defined GCC_PRINTFLIKE if GCC_PRINTFLIKE was already defined.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

commit 7843f1e00caba67025ac75c4985ddd3af7924a9c
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jun 2 20:38:29 2011 -0700

    Use C99 named initializers for XSetWindowAttributes structure
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

commit 3c3f9cde9dda4c74178cc5428ebf8967c26a516a
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Thu Jun 2 18:33:56 2011 -0700

    Bug 13455: allowNullPasswd: true doesn't work until the second login attempt
    
    Assign allow_null_passwd and allow_root_login variables' values before call to
    pam_authenticate()
    
    https://bugs.freedesktop.org/show_bug.cgi?id=13455
    
    Based on a fix suggested by: Tim Shumakov <ars_1 at mail.ru>
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

commit 7d69ff7b9dfcd3e4410f181225f66f51089eef67
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri May 27 22:46:09 2011 -0700

    On Solaris, make sure PAM_TTY is only ever set to an actual /dev path
    
    Solaris PAM & auditing insist this is a device file that can be found in
    the filesystem, so we can't use the display name (":0") like we've
    been doing (and continue to do on other OS'es).
    
    Fixes Solaris bug 6960231:
    xdm login fails with: pam_unix_cred: cannot load ttyname with c2audit loaded
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>