libX11: Changes to 'master'

Adam Jackson ajax at kemper.freedesktop.org
Mon Jan 3 09:27:28 PST 2011


 src/XlibInt.c |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit b2bb9104207e9911f9a5558e4040163287282d04
Author: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
Date:   Mon Jan 3 12:25:28 2011 -0500

    Initialize event type
    
    If we receive unsupported event closing connection triggers valgrind
    error.
    
    ==12017== Conditional jump or move depends on uninitialised value(s)
    ==12017==    at 0x487D454: _XFreeDisplayStructure (OpenDis.c:607)
    ==12017==    by 0x486857B: XCloseDisplay (ClDisplay.c:72)
    *snip*
    ==12017==  Uninitialised value was created by a heap allocation
    ==12017==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
    ==12017==    by 0x4894147: _XEnq (XlibInt.c:877)
    ==12017==    by 0x4891BF3: handle_response (xcb_io.c:335)
    ==12017==    by 0x4892263: _XReply (xcb_io.c:626)
    *snip*
    
    Problem is that XFreeDisplaySturture is checking for qelt->event.type ==
    GenericEvent while _XUnknownWireEvent doesn't store the type.
    
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
    Signed-off-by: Pauli Nieminen <ext-pauli.nieminen at nokia.com>



More information about the xorg-commit mailing list