xman: Changes to 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Tue Feb 1 19:58:50 PST 2011


 buttons.c |    7 +++---
 handler.c |   30 ++++++++++++--------------
 main.c    |    6 ++---
 man.h     |    2 -
 misc.c    |   69 ++++++++++++++++++++++++++++----------------------------------
 vendor.c  |    6 ++---
 6 files changed, 57 insertions(+), 63 deletions(-)

New commits:
commit ca7ff690136a35b8dad90271db5966cc9614b1c1
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri Jan 28 23:10:22 2011 -0800

    Use snprintf to PATH_MAX sized buffers to construct filenames
    
    Simpler than trying to calculate the size to malloc.
    
    Could have used XtAsprintf() but didn't seem worth the dependency
    for two simple calls with a standard, well-known maximum size.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Dirk Wallenstein <halsmit at t-online.de>

commit 48709d1ed5002255fa322cb3f0c4b8d5a5a7f3de
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri Jan 28 22:38:08 2011 -0800

    Convert more sprintf calls to snprintf
    
    Previous conversion seems to have missed many calls right next to ones
    that were converted to snprintf already
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Dirk Wallenstein <halsmit at t-online.de>

commit 35265840bba5aa4098b2f12522ef4c80b17c604a
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri Jan 28 22:35:35 2011 -0800

    Don't need to copy static strings to a buffer before calling PopupWarning
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Dirk Wallenstein <halsmit at t-online.de>

commit 72817de248a160ae84532662268b380b701908e8
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Fri Jan 28 22:24:47 2011 -0800

    Mark string argument to PopupWarning as a const char *
    
    PopupWarning just copies the string into the message it displays,
    via snprintf, and never writes to it.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Dirk Wallenstein <halsmit at t-online.de>



More information about the xorg-commit mailing list