libICE: Changes to 'master'
Alan Coopersmith
alanc at kemper.freedesktop.org
Thu Apr 21 16:04:50 PDT 2011
include/X11/ICE/ICEmsg.h | 6 +++---
src/error.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit dd7f2beaa753541aefba499813f25de38cbd17b7
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Tue Apr 19 18:36:58 2011 -0700
IceWritePad: Zero fill pad bytes used when buffer is full
Should be rarely hit, since it's only in the case where most of the
message fits in the buffer, but there's not room left for the padding
bytes, but better than sending uninitialized bytes off the stack when
it happens.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
commit 663782989be82e7893c99eaa7cbe98ec25a23c38
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Tue Apr 19 18:19:19 2011 -0700
Fix reads outside array bounds in error handlers
Error: Buffer overrun
Read outside array bounds (CWE 125): In call to memcpy(<unknown>, &mOp, 8), (size(&mOp) < (unsigned) 8)
Array size is 1 bytes
at line 296 of src/error.c in function '_IceErrorMajorOpcodeDuplicate'.
Error: Buffer overrun
Read outside array bounds (CWE 125): In call to memcpy(<unknown>, &maj, 8), (size(&maj) < (unsigned) 8)
Array size is 1 bytes
at line 346 of src/error.c in function '_IceErrorBadMajor'.
[ This bug was found by the Parfait 0.3.7 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
More information about the xorg-commit
mailing list