xf86-input-synaptics:master: 22 commit(s)

Sun Apr 3 16:41:52 PDT 2011

Reporting from xf86-input-synaptics: xf86-input-synaptics driver

Please visit:
    http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics
Or get your own copy by using:
    git-clone git://anongit.freedesktop.org/xorg/driver/xf86-input-synaptics

22 commits against master at 43c3720c...:
 Makefile.am               |    2 
 conf/11-x11-synaptics.fdi |   10 -
 conf/50-synaptics.conf    |    9 
 configure.ac              |    8 
 man/synaptics.man         |   17 -
 src/eventcomm.c           |  344 ++++++++++++++++++++++-------------
 src/eventcomm.h           |    6 
 src/synaptics.c           |    2 
 src/synproto.h            |    2 
 test/.gitignore           |    6 
 test/Makefile.am          |   15 +
 test/eventcomm-test.c     |  285 +++++++++++++++++++++++++++++
 test/fake-symbols.c       |  446 ++++++++++++++++++++++++++++++++++++++++++++++
 test/fake-symbols.h       |  177 ++++++++++++++++++
 14 files changed, 1182 insertions(+), 147 deletions(-)


commit 2898098469457a0d7c3d3610065ccc75c46bdfa0
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Tue Mar 22 11:51:48 2011 +1000

    Only build tests when unit tests are enabled.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

diffstat:
    test/Makefile.am |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 99822503c8991ebf4eed3390904b5e62b0775d31
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Mon Mar 21 10:24:21 2011 +1000

    test: add another test to ensure HW state changes on known values only.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    test/eventcomm-test.c |   95 ++++++++++++++++++++++++++++++++++++++++++++++
    1 file changed, 95 insertions(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit be52f449c148028ee912aa12ea9a91ed28590a9e
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 11:02:45 2011 +1000

    test: Add some tests for HW state changes.
    
    Includes basic finger counting test, some button tests and axis tests. These
    tests simply check that the HW state changes reflect the events pumped in.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    test/Makefile.am      |    1 
    test/eventcomm-test.c |  153 ++++++++++++++++++++++++++++++++++++++++++++++
    2 files changed, 154 insertions(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 9290ce357b5063e8170f28282711718794a3c2d0
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 20:34:38 2011 +1000

    Add basic framework for unit-testing.
    
    Also adds a bunch of fake symbols so we can link. Note that any of these
    symbols will return false, 0 or whatever the zero value for the symbol is.
    Care must be taken when writing test that this doesn't screw up the test.
    
    Tests are always built but only run on make check.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    Makefile.am           |    2 
    configure.ac          |    2 
    test/.gitignore       |    6 
    test/Makefile.am      |   14 +
    test/eventcomm-test.c |   37 +++
    test/fake-symbols.c   |  446 ++++++++++++++++++++++++++++++++++++++++++++++
    test/fake-symbols.h   |  177 ++++++++++++++++++
    7 files changed, 683 insertions(+), 1 deletion(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit bc89d7db428dbf38a9f0f9b5f5e8efd1afae71f1
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 20:26:18 2011 +1000

    Require macros 1.13 for unit testing
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

diffstat:
    configure.ac |    6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 241254e352f5c4e3d6850e0916261cb235c6b608
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Mon Mar 21 11:23:34 2011 +1000

    Don't autoprobe for devices when Option Device is set.
    
    If only Option Device is set but no protocol, the code calls into
    AutoDevProbe. eventcomm (the only backend with an AutoDevProbe) then runs
    through all /dev/input/event devices and takes the first one it can find.
    
    If two touchpads are connected on a system, this may cause the same touchpad
    to be added twice and the other one not at all - even though the device path
    is specified. (This can only happen when the event device is not grabbed,
    otherwise the grabcheck prevents the touchpad from being added twice)
    
    Pass the device option into AutoDevProbe and check that device first. If it
    is a touchpad, finish with success. If it isn't, fail AutoDevProbe.
    
    Introduced in dce6006f6a851be4147e16731caa453dd0d1ec1c.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    CC: Alexandr Shadchin <alexandr.shadchin at gmail.com>
    Reviewed-by: Chris Bagwell <chris at cnpbagwell.com>

diffstat:
    src/eventcomm.c |   18 +++++++++++++++++-
    src/synaptics.c |    2 +-
    src/synproto.h  |    2 +-
    3 files changed, 19 insertions(+), 3 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit f65f8a8365b158cbdb6cdc3f74afc08a2653c084
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Mon Mar 21 11:14:50 2011 +1000

    eventcomm: fix indentation in EventAutoDevProbe
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |   12 +++++++-----
    1 file changed, 7 insertions(+), 5 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 3277733209180d94f67be8019178424dbe17fc5b
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 10:33:57 2011 +1000

    eventcomm: move need_grab into a proto-specific struct.
    
    Don't just assign a BOOL to proto_data, use a struct for readability.
    This changes nothing in the code, especially since need_grab is always
    false.
    
    The current code assumes that if a proto_data field is present, we respect
    the need_grab from this field. Otherwise, we always try to grab.
    need_grab is however always FALSE, so all this is mostly for readability, if
    not necessarily understandability...
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    src/eventcomm.c |   35 ++++++++++++++++++++++-------------
    1 file changed, 22 insertions(+), 13 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 810423b51706ea26c6794eaf6cd51fcbb56386ad
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 10:22:18 2011 +1000

    eventcomm: untangle state setting from printing device info
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Chris Bagwell <chris at cnpbagwell.com>

diffstat:
    src/eventcomm.c |   97 ++++++++++++++++++++++++++--------------------------
    1 file changed, 50 insertions(+), 47 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit dacac616305cc38cab082607c0e40c109cb8422e
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 10:14:05 2011 +1000

    eventcomm: print an error when axis range failed.
    
    Judging by a quick google search, this isn't a common error that the user
    will see, it's a bug. So print out information useful for those
    triaging/debugging.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |   11 ++++-------
    1 file changed, 4 insertions(+), 7 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit a0aa59ed5d0ab07702c3bc56cf5651d193e553a7
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 10:09:56 2011 +1000

    eventcomm: streamline absinfo retrieval.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    src/eventcomm.c |  104 ++++++++++++++++++++++++++++++----------------------
    1 file changed, 61 insertions(+), 43 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 2122ad2f17c0efed016d41178e2da9d3eeba84fd
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 09:46:26 2011 +1000

    eventcomm: rewrite event_query_info to something more sane
    
    Instead of passing in a magic struct and set fields in that struct, pass in
    the fd that we query and return the queried value. Let the caller deal with
    the information accordingly.
    
    And document the lot.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |   25 ++++++++++++++++++-------
    1 file changed, 18 insertions(+), 7 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 7b2d245ee1ecc3793f29dbf2761ef1ab73a577e5
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 09:38:13 2011 +1000

    eventcomm: document event_query_is_touchpad
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |   14 ++++++++++++++
    1 file changed, 14 insertions(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit a16e51c4aca95b35d929b059dc027bb0fec5405d
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 09:36:52 2011 +1000

    eventcomm: rename parameter name grab to test_grab
    
    We don't permanently grab the device here, we just check whether a grab is
    possible.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |    6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 13543b156d78bc4d01a19844a5ee8f283269621b
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Sun Mar 20 09:28:45 2011 +1000

    eventcomm: replace synaptics-custom TEST_BIT with server's BitIsOn.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |   41 +++++++++++++++++++----------------------
    1 file changed, 19 insertions(+), 22 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit adf3e8a5f9e3efc7e7a5d4148cf509f00cade9e0
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 21:36:19 2011 +1000

    eventcomm: extern EventReadHwState to allow for testing.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |    2 +-
    src/eventcomm.h |    6 ++++++
    2 files changed, 7 insertions(+), 1 deletion(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 453c5bf6ec0de358ec845946835fcb738cf9af80
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 21:06:16 2011 +1000

    eventcomm: factor out finger counting.
    
    one, two, three, many.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |   32 ++++++++++++++++++++++++--------
    1 file changed, 24 insertions(+), 8 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit ecf42db47629cadc7a332398a1784bb0acbd6511
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 20:56:51 2011 +1000

    eventcomm: add a missing break statement
    
    If the EV_SYN wasn't SYN_REPORT, we'd fall through to key event processing,
    which almost certainly won't do what we want and/or need.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Cyril Brulebois <kibi at debian.org>

diffstat:
    src/eventcomm.c |    1 +
    1 file changed, 1 insertion(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit b7acee2346494846e80d2fe25f699081a51c49a2
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 10:34:03 2011 +1000

    conf: add a descriptive header with warning to example config file
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    conf/11-x11-synaptics.fdi |    7 +++++++
    conf/50-synaptics.conf    |    9 +++++++++
    2 files changed, 16 insertions(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit bc01d6a88ae84a0b1e52b8feb93c168d5120cd58
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 10:40:50 2011 +1000

    conf: remove SHM example from fdi
    
    SHM is dead for configuration.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    conf/11-x11-synaptics.fdi |    3 ---
    1 file changed, 3 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 5f546777173dc78146025499d186fe97d31eaeac
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 10:29:37 2011 +1000

    man: add short blurb about InputClass configuration in servers 1.8
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    man/synaptics.man |    6 ++++++
    1 file changed, 6 insertions(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984


commit 86cab92b41443a5c9391b3bb20c93d902cf67961
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Mar 18 10:26:37 2011 +1000

    man: update source path for fdi file and shorten description.
    
    Don't describe what the example config file does in the man page, let the
    file speak for itself. Point out that fdi files are for servers 1.5 - 1.7
    only.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    man/synaptics.man |   11 +++--------
    1 file changed, 3 insertions(+), 8 deletions(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=28980984