xf86-video-intel: src/intel_display.c

Chris Wilson ickle at kemper.freedesktop.org
Sun Oct 17 01:25:46 PDT 2010


 src/intel_display.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 33133a1d38a4dce60d2e135663b545895fc85abc
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Sun Oct 17 09:21:06 2010 +0100

    display: do not report failure for setting unrecognised properties
    
    We need to accept any changes to properties not handled by ourselves -- we
    can't validate the changes ourselves. Denying those changes breaks EDID
    reporting, for example.
    
    Reported-by: Elvis Pranskevichus <el at prans.net>
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/intel_display.c b/src/intel_display.c
index 74ce736..d32224e 100644
--- a/src/intel_display.c
+++ b/src/intel_display.c
@@ -1161,7 +1161,11 @@ intel_output_set_property(xf86OutputPtr output, Atom property,
 		}
 	}
 
-	return FALSE;
+	/* We didn't recognise this property, just report success in order
+	 * to allow the set to continue, otherwise we break setting of
+	 * common properties like EDID.
+	 */
+	return TRUE;
 }
 
 static Bool


More information about the xorg-commit mailing list