xserver: Branch 'master'

Keith Packard keithp at kemper.freedesktop.org
Wed Oct 13 09:46:44 PDT 2010


 mi/mieq.c |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit da4eebe58ec81e2297cc1773af1fb622fb392bbd
Author: Jon TURNEY <jon.turney at dronecode.org.uk>
Date:   Wed Oct 13 17:34:31 2010 +0100

    event_size is currently never assigned to in mieqProcessInputEvents().
    
    event_size is never assigned to in mieqProcessInputEvents(), so realloc()
    is always called.  This is benign, but I'm guessing not intended.
    
    Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>
    Reviewed-by: Keith Packard <keithp at keithp.com>
    Signed-off-by: Keith Packard <keithp at keithp.com>

diff --git a/mi/mieq.c b/mi/mieq.c
index fa60b40..d1441e2 100644
--- a/mi/mieq.c
+++ b/mi/mieq.c
@@ -439,7 +439,11 @@ mieqProcessInputEvents(void)
 
         evlen   = e->events->evlen;
         if(evlen > event_size)
+          {
             event = realloc(event, evlen);
+            event_size = evlen;
+          }
+
 
         if (!event)
             FatalError("[mi] No memory left for event processing.\n");


More information about the xorg-commit mailing list