xf86-input-synaptics:master: 2 commit(s)

Peter Hutterer whot at kemper.freedesktop.org
Mon Oct 4 21:37:05 PDT 2010


Reporting from xf86-input-synaptics: xf86-input-synaptics driver

Please visit:
    http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics
Or get your own copy by using:
    git-clone git://anongit.freedesktop.org/xorg/driver/xf86-input-synaptics

2 commits against master at 6f7daad9...:
 src/synaptics.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


commit f5687a6741a19ef3081e7fd83ac55f6df8bcd5c2
Author: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
Date:   Sun Sep 19 09:49:59 2010 +0200

    config: don't autoprobe when device was set
    
    If device was already set, we were asked to handle that specific device
    and we should not go probing around. If we do, we might end up handling
    a device different from what the X server thinks we are handling, with
    dire consequences in case of hot plugging and unplugging.
    
    Without this patch, a situation such as the following can happen.
    
    A user has both a built-in laptop touchpad and a tablet such as the
    Wacom Bamboo Pen & Touch, that is also exposed as a touchpad.
    
    The tablet is plugged in before the server starts, and during setup the
    server calls the synaptic driver for the /dev/input/mouseX device
    corresponding to the touch device of the tablet; we end up in the
    autoprobe path even though `device' was set, and the driver scans
    /dev/input, where the first useful device it finds is the event device
    for the built-in touchpad.
    
    The driver starts managing the built-in touchpad, preventing future
    instances from managing it too, while the server thinks the driver is
    managing the tablet.
    
    When the user disconnects the tablet, the corresponding instance of the
    synpatics driver (which is actually managing the touchpad instead) is
    unloaded: the built-in touchpad stops working in X.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
    Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    src/synaptics.c |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=f5687a67


commit f2039cb7fba41032ec87315a3a4511472a5ef0dc
Author: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
Date:   Wed Sep 22 21:44:13 2010 +0200

    config: collect options during preinit
    
    This must to ensure that the "Device" option is set correctly before
    SetDeviceAndProtocol is called, but it's only needed when the old input
    API is used.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

diffstat:
    src/synaptics.c |    2 ++
    1 file changed, 2 insertions(+)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=f5687a67




More information about the xorg-commit mailing list